Hoo man has uploaded a new change for review.
https://gerrit.wikimedia.org/r/257807
Change subject: Revert "Remove newTermSearchInteractor from WikibaseClient"
......................................................................
Revert "Remove newTermSearchInteractor from WikibaseClient"
Needed by the ArticlePlaceholder.
This reverts commit 89dd565dcb5efc055d3f779168f439af3cdfff6b.
Change-Id: I671f5e8941638270998c8035a1d25dbda7d79d09
---
M client/includes/WikibaseClient.php
M client/tests/phpunit/includes/WikibaseClientTest.php
2 files changed, 20 insertions(+), 0 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Wikibase
refs/changes/07/257807/1
diff --git a/client/includes/WikibaseClient.php
b/client/includes/WikibaseClient.php
index 77565da..99d54e7 100644
--- a/client/includes/WikibaseClient.php
+++ b/client/includes/WikibaseClient.php
@@ -61,6 +61,7 @@
use Wikibase\Lib\Store\EntityContentDataCodec;
use Wikibase\Lib\WikibaseContentLanguages;
use Wikibase\Lib\WikibaseValueFormatterBuilders;
+use Wikibase\Lib\Interactors\TermIndexSearchInteractor;
use Wikibase\NamespaceChecker;
use Wikibase\SettingsArray;
use Wikibase\SiteLinkCommentCreator;
@@ -292,6 +293,20 @@
}
/**
+ * @param string $displayLanguageCode
+ *
+ * @return TermIndexSearchInteractor
+ */
+ public function newTermSearchInteractor( $displayLanguageCode ) {
+ return new TermIndexSearchInteractor(
+ $this->getStore()->getTermIndex(),
+ $this->getLanguageFallbackChainFactory(),
+ $this->getBufferingTermLookup(),
+ $displayLanguageCode
+ );
+ }
+
+ /**
* @since 0.4
*
* @return PropertyDataTypeLookup
diff --git a/client/tests/phpunit/includes/WikibaseClientTest.php
b/client/tests/phpunit/includes/WikibaseClientTest.php
index b376f57..406c0ed 100644
--- a/client/tests/phpunit/includes/WikibaseClientTest.php
+++ b/client/tests/phpunit/includes/WikibaseClientTest.php
@@ -51,6 +51,11 @@
$this->assertInstanceOf(
'Wikibase\DataModel\Entity\EntityIdParser', $returnValue );
}
+ public function testNewTermSearchInteractor() {
+ $interactor =
$this->getWikibaseClient()->newTermSearchInteractor( 'en' );
+ $this->assertInstanceOf(
'Wikibase\Lib\Interactors\TermIndexSearchInteractor', $interactor );
+ }
+
public function testGetPropertyDataTypeLookupReturnType() {
$returnValue =
$this->getWikibaseClient()->getPropertyDataTypeLookup();
$this->assertInstanceOf(
'Wikibase\DataModel\Services\Lookup\PropertyDataTypeLookup', $returnValue );
--
To view, visit https://gerrit.wikimedia.org/r/257807
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I671f5e8941638270998c8035a1d25dbda7d79d09
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Hoo man <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
