Legoktm has uploaded a new change for review. https://gerrit.wikimedia.org/r/257836
Change subject: Revert "CharacterBeforePHPOpeningTagSniff: Support T_HASHBANG for HHVM >=3.5,<3.7" ...................................................................... Revert "CharacterBeforePHPOpeningTagSniff: Support T_HASHBANG for HHVM >=3.5,<3.7" My upstream patch to address this is included in 2.4.0: <https://github.com/squizlabs/PHP_CodeSniffer/pull/669>. This reverts commit 7cf13be7ba88e9a1e24551bdd949899ae61bfef5. Change-Id: I7f6806d252e04753e39197d5fad18c52d6000d1f --- M MediaWiki/Sniffs/ExtraCharacters/CharacterBeforePHPOpeningTagSniff.php 1 file changed, 1 insertion(+), 2 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/tools/codesniffer refs/changes/36/257836/1 diff --git a/MediaWiki/Sniffs/ExtraCharacters/CharacterBeforePHPOpeningTagSniff.php b/MediaWiki/Sniffs/ExtraCharacters/CharacterBeforePHPOpeningTagSniff.php index e8a419d..a27df2b 100644 --- a/MediaWiki/Sniffs/ExtraCharacters/CharacterBeforePHPOpeningTagSniff.php +++ b/MediaWiki/Sniffs/ExtraCharacters/CharacterBeforePHPOpeningTagSniff.php @@ -31,8 +31,7 @@ // so the first token is on the first line // check if it is valid shebang - // T_HASHBANG is a token used in HHVM >=3.5, <3.7 (T103119) - if ( in_array( $tokens[0]['type'], array( 'T_INLINE_HTML', 'T_HASHBANG' ) ) + if ( $tokens[0]['type'] == 'T_INLINE_HTML' && substr( $tokens[0]['content'], 0, 2 ) == '#!' ) { $validShebang = true; } -- To view, visit https://gerrit.wikimedia.org/r/257836 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I7f6806d252e04753e39197d5fad18c52d6000d1f Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/tools/codesniffer Gerrit-Branch: master Gerrit-Owner: Legoktm <[email protected]> _______________________________________________ MediaWiki-commits mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
