jenkins-bot has submitted this change and it was merged.
Change subject: Fix EntityIdValueParser return type
......................................................................
Fix EntityIdValueParser return type
Change-Id: Ie771c502d0685bbfdd60c50c5c55cf047aed176d
---
M repo/includes/Parsers/EntityIdValueParser.php
1 file changed, 2 insertions(+), 3 deletions(-)
Approvals:
Aude: Looks good to me, approved
JanZerebecki: Looks good to me, approved
jenkins-bot: Verified
diff --git a/repo/includes/Parsers/EntityIdValueParser.php
b/repo/includes/Parsers/EntityIdValueParser.php
index bc7e04c..0856af4 100644
--- a/repo/includes/Parsers/EntityIdValueParser.php
+++ b/repo/includes/Parsers/EntityIdValueParser.php
@@ -4,10 +4,9 @@
use ValueParsers\ParseException;
use ValueParsers\StringValueParser;
-use Wikibase\DataModel\Entity\EntityId;
-use Wikibase\DataModel\Entity\EntityIdValue;
use Wikibase\DataModel\Entity\EntityIdParser;
use Wikibase\DataModel\Entity\EntityIdParsingException;
+use Wikibase\DataModel\Entity\EntityIdValue;
/**
* Parser that parses entity id strings into EntityIdValue objects.
@@ -43,8 +42,8 @@
*
* @param string $value
*
- * @return EntityId
* @throws ParseException
+ * @return EntityIdValue
*/
protected function stringParse( $value ) {
try {
--
To view, visit https://gerrit.wikimedia.org/r/257593
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ie771c502d0685bbfdd60c50c5c55cf047aed176d
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Thiemo Mättig (WMDE) <[email protected]>
Gerrit-Reviewer: Aude <[email protected]>
Gerrit-Reviewer: Daniel Kinzler <[email protected]>
Gerrit-Reviewer: JanZerebecki <[email protected]>
Gerrit-Reviewer: Jeroen De Dauw <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
