DLynch has submitted this change and it was merged.
Change subject: Fix more typos
......................................................................
Fix more typos
Add a common ones (found in multiple repos) to typos.json.
Change-Id: I6b787fcc3d6e7db2876f2a8d463125d4b8190644
---
M build/typos.json
M src/ce/keydownhandlers/ve.ce.LinearEscapeKeyDownHandler.js
M src/ce/ve.ce.KeyDownHandlerFactory.js
M src/ce/ve.ce.Surface.js
M src/ce/ve.ce.TextState.js
M src/dm/annotations/ve.dm.LinkAnnotation.js
M src/dm/ve.dm.APIResultsProvider.js
M src/dm/ve.dm.APIResultsQueue.js
M src/dm/ve.dm.Document.js
M src/ui/contexts/ve.ui.LinearContext.js
M src/ui/dialogs/ve.ui.ToolbarDialog.js
M src/ui/ve.ui.ContextItem.js
M src/ui/ve.ui.ModeledFactory.js
M src/ve.SelectionState.js
14 files changed, 27 insertions(+), 26 deletions(-)
Approvals:
DLynch: Looks good to me, approved
jenkins-bot: Verified
diff --git a/build/typos.json b/build/typos.json
index b9a8e62..79ad3cb 100644
--- a/build/typos.json
+++ b/build/typos.json
@@ -11,6 +11,7 @@
[ "contian", "contain" ],
[ "occured", "occurred" ],
[ "pgk", "pkg" ],
- [ "arrray", "array" ]
+ [ "arrray", "array" ],
+ [ "overriden", "overridden" ]
]
}
diff --git a/src/ce/keydownhandlers/ve.ce.LinearEscapeKeyDownHandler.js
b/src/ce/keydownhandlers/ve.ce.LinearEscapeKeyDownHandler.js
index d492712..4bcec9c 100644
--- a/src/ce/keydownhandlers/ve.ce.LinearEscapeKeyDownHandler.js
+++ b/src/ce/keydownhandlers/ve.ce.LinearEscapeKeyDownHandler.js
@@ -43,7 +43,7 @@
e.stopPropagation();
tableNode.setEditing( false );
// if this was a merged cell, we're going to have unexpected
behavior when the selection moves,
- // so pre-emptatively collapse to the top-left point of the
merged cell.
+ // so preemptively collapse to the top-left point of the merged
cell.
surface.getModel().setSelection(
surface.getModel().getSelection().collapseToStart() );
return true;
}
diff --git a/src/ce/ve.ce.KeyDownHandlerFactory.js
b/src/ce/ve.ce.KeyDownHandlerFactory.js
index 037c3c5..3f21b52 100644
--- a/src/ce/ve.ce.KeyDownHandlerFactory.js
+++ b/src/ce/ve.ce.KeyDownHandlerFactory.js
@@ -47,7 +47,7 @@
* Get the handler for a specific key
*
* @param {number} key Key code
- * @param {string} selectionName Selection type nane
+ * @param {string} selectionName Selection type name
* @return {Function[]} Matched handlers
*/
ve.ce.KeyDownHandlerFactory.prototype.lookupHandlersForKey = function ( key,
selectionName ) {
@@ -71,7 +71,7 @@
* Execute the handlers for a specific key
*
* @param {number} key Key code
- * @param {string} selectionName Selection type nane
+ * @param {string} selectionName Selection type name
* @param {ve.ce.Surface} surface Surface
* @param {jQuery} e Key down event
* @return {boolean} Some handlers acted
diff --git a/src/ce/ve.ce.Surface.js b/src/ce/ve.ce.Surface.js
index 98cbb67..8cf4ac5 100644
--- a/src/ce/ve.ce.Surface.js
+++ b/src/ce/ve.ce.Surface.js
@@ -134,7 +134,7 @@
} else {
// fake selection change events; mousemove gets optimized away
if we're not dragging
// mousedown needs to run after nativemousedown, because
otherwise the selection hasn't
- // finished changigng
+ // finished changing
this.$documentNode.on( 'mousemove',
this.onDocumentSelectionChange.bind( this ) );
this.eventSequencer.after( {
mousedown: this.onDocumentSelectionChange.bind( this )
@@ -527,7 +527,7 @@
*/
ve.ce.Surface.prototype.deactivate = function () {
if ( !this.deactivated ) {
- // Disable the surface observer, there can be no observeable
changes
+ // Disable the surface observer, there can be no observable
changes
// until the surface is activated
this.surfaceObserver.disable();
this.deactivated = true;
@@ -1073,7 +1073,7 @@
*
* If any of these triggers can't execute on the surface, (e.g. the underline
* command has been blacklisted), we should still preventDefault so
ContentEditable
- * native commands don't occur, leving the view out of sync with the model.
+ * native commands don't occur, leaving the view out of sync with the model.
*
* @method
* @param {ve.ui.Trigger} trigger Trigger to check
@@ -1163,7 +1163,7 @@
$focusNode = $( focusNode );
// If the first ancestor with contenteditable set is ce=true,
then we are allowed
- // to be inside this focusalbe node (e.g. editing a table cell
or caption)
+ // to be inside this focusable node (e.g. editing a table cell
or caption)
if ( $focusNode.closest( '[contenteditable]' ).prop(
'contenteditable' ) === 'true' ) {
return null;
}
@@ -2021,7 +2021,7 @@
*
* @param {DataTransfer} dataTransfer Data transfer
* @param {boolean} isPaste Handlers being used for paste
- * @param {ve.dm.SurfaceFragment} [targetFragment] Fragment to inserto data
items at, defaults to current selection
+ * @param {ve.dm.SurfaceFragment} [targetFragment] Fragment to insert data
items at, defaults to current selection
* @return {boolean} One more items was handled
*/
ve.ce.Surface.prototype.handleDataTransfer = function ( dataTransfer, isPaste,
targetFragment ) {
@@ -2058,11 +2058,11 @@
};
/**
- * Handle the insertion of data tranfer items
+ * Handle the insertion of data transfer items
*
* @param {ve.ui.DataTransferItem[]} items Data transfer items
* @param {boolean} isPaste Handlers being used for paste
- * @param {ve.dm.SurfaceFragment} [targetFragment] Fragment to inserto data
items at, defaults to current selection
+ * @param {ve.dm.SurfaceFragment} [targetFragment] Fragment to insert data
items at, defaults to current selection
* @return {boolean} One more items was handled
*/
ve.ce.Surface.prototype.handleDataTransferItems = function ( items, isPaste,
targetFragment ) {
@@ -3101,7 +3101,7 @@
};
/**
- * Get the linkAnnotation node containing the cursor fous
+ * Get the linkAnnotation node containing the cursor focus
*
* If there is no focus, or it is not inside a linkAnnotation, return null
*
diff --git a/src/ce/ve.ce.TextState.js b/src/ce/ve.ce.TextState.js
index ea57f4f..536d52c 100644
--- a/src/ce/ve.ce.TextState.js
+++ b/src/ce/ve.ce.TextState.js
@@ -334,7 +334,7 @@
}
if ( annotations === null ) {
// No exact match: search for the old chunk whose
element list covers best
- // (chosing the startmost of any tying chunks). There
may be no missing
+ // (choosing the startmost of any tying chunks). There
may be no missing
// elements even though the match is not exact (e.g.
because of removed
// annotations and reordering).
//
diff --git a/src/dm/annotations/ve.dm.LinkAnnotation.js
b/src/dm/annotations/ve.dm.LinkAnnotation.js
index 178090b..f60d1ca 100644
--- a/src/dm/annotations/ve.dm.LinkAnnotation.js
+++ b/src/dm/annotations/ve.dm.LinkAnnotation.js
@@ -74,7 +74,7 @@
/**
* Get the display title for this link
*
- * Can be overriden by special link types.
+ * Can be overridden by special link types.
*
* @return {string} Display title
*/
diff --git a/src/dm/ve.dm.APIResultsProvider.js
b/src/dm/ve.dm.APIResultsProvider.js
index 76c6f4e..cff9549 100644
--- a/src/dm/ve.dm.APIResultsProvider.js
+++ b/src/dm/ve.dm.APIResultsProvider.js
@@ -117,7 +117,7 @@
* @param {Object} params User defined data parameters
*/
ve.dm.APIResultsProvider.prototype.setUserParams = function ( params ) {
- // Assymetrically compare (params is subset of this.userParams)
+ // Asymmetrically compare (params is subset of this.userParams)
if ( !ve.compare( params, this.userParams, true ) ) {
this.userParams = $.extend( {}, this.userParams, params );
// Reset offset
diff --git a/src/dm/ve.dm.APIResultsQueue.js b/src/dm/ve.dm.APIResultsQueue.js
index b7d7d61..ef0ac0d 100644
--- a/src/dm/ve.dm.APIResultsQueue.js
+++ b/src/dm/ve.dm.APIResultsQueue.js
@@ -41,7 +41,7 @@
/**
* Set up the queue and its resources.
- * This should be overrided if there are any setup steps to perform.
+ * This should be overridden if there are any setup steps to perform.
*
* @return {jQuery.Promise} Promise that resolves when the resources
* are set up. Note: The promise must have an .abort() functionality.
@@ -157,7 +157,7 @@
};
/**
- * Add a provbider to the group
+ * Add a provider to the group
*
* @param {ve.dm.APIResultsProvider} provider A provider object
*/
diff --git a/src/dm/ve.dm.Document.js b/src/dm/ve.dm.Document.js
index b8fd7ac..d0e1b17 100644
--- a/src/dm/ve.dm.Document.js
+++ b/src/dm/ve.dm.Document.js
@@ -1304,7 +1304,7 @@
* @param {Object} [options] Search options
* @param {boolean} [options.caseSensitiveString] Case sensitive search for a
string query. Ignored by regexes (use 'i' flag).
* @param {boolean} [options.noOverlaps] Avoid overlapping matches
- * @param {boolean} [options.wholeWord] Only match whole-word occurences
+ * @param {boolean} [options.wholeWord] Only match whole-word occurrences
* @return {ve.Range[]} List of ranges where the string was found
*/
ve.dm.Document.prototype.findText = function ( query, options ) {
diff --git a/src/ui/contexts/ve.ui.LinearContext.js
b/src/ui/contexts/ve.ui.LinearContext.js
index 1ced0ce..a7ca907 100644
--- a/src/ui/contexts/ve.ui.LinearContext.js
+++ b/src/ui/contexts/ve.ui.LinearContext.js
@@ -96,7 +96,7 @@
ve.ui.LinearContext.prototype.onDocumentUpdate = function () {
// Only mind this event if the menu is visible
if ( this.isVisible() && !this.isEmpty() ) {
- // Reuse the debounced context change hanlder
+ // Reuse the debounced context change handler
this.onContextChange();
}
};
diff --git a/src/ui/dialogs/ve.ui.ToolbarDialog.js
b/src/ui/dialogs/ve.ui.ToolbarDialog.js
index 1772463..3f7a2eb 100644
--- a/src/ui/dialogs/ve.ui.ToolbarDialog.js
+++ b/src/ui/dialogs/ve.ui.ToolbarDialog.js
@@ -66,7 +66,7 @@
if ( disabled !== this.disabled ) {
this.disabled = disabled;
this.$body
- // Make sure sheild is last child
+ // Make sure shield is last child
.append( this.$shield )
.toggleClass( 've-ui-toolbarDialog-disabled',
this.disabled );
}
diff --git a/src/ui/ve.ui.ContextItem.js b/src/ui/ve.ui.ContextItem.js
index 04657d0..b52f5e7 100644
--- a/src/ui/ve.ui.ContextItem.js
+++ b/src/ui/ve.ui.ContextItem.js
@@ -94,7 +94,7 @@
/**
* Check if model is a node
*
- * @return {boolean} Model is a nodel
+ * @return {boolean} Model is a node
*/
ve.ui.ContextItem.prototype.isNode = function () {
return this.model && this.model instanceof ve.dm.Node;
diff --git a/src/ui/ve.ui.ModeledFactory.js b/src/ui/ve.ui.ModeledFactory.js
index be5d396..469440e 100644
--- a/src/ui/ve.ui.ModeledFactory.js
+++ b/src/ui/ve.ui.ModeledFactory.js
@@ -41,7 +41,7 @@
* Collect the most specific compatible classes for a model.
*
* @private
- * @param {Object} model Model to find compatability with
+ * @param {Object} model Model to find compatibility with
* @return {Function[]} List of compatible classes
*/
function collect( model ) {
diff --git a/src/ve.SelectionState.js b/src/ve.SelectionState.js
index 23436e7..01158ae 100644
--- a/src/ve.SelectionState.js
+++ b/src/ve.SelectionState.js
@@ -14,10 +14,10 @@
*
* @constructor
* @param {ve.SelectionState|Selection|Object} selection DOM Selection-like
object
- * @param {Node|null} selection.anchorNode the Anchor node (null if no
selection)
- * @param {number} selection.anchorOffset the Anchor offset (0 if no selection)
- * @param {Node|null} selection.focusNode the Focus node (null if no selection)
- * @param {number} selection.focusOffset the Focusoffset (0 if no selection)
+ * @param {Node|null} selection.anchorNode The anchor node (null if no
selection)
+ * @param {number} selection.anchorOffset The anchor offset (0 if no selection)
+ * @param {Node|null} selection.focusNode The focus node (null if no selection)
+ * @param {number} selection.focusOffset The focus offset (0 if no selection)
* @param {boolean} [selection.isCollapsed] Whether the anchor and focus are
the same
* @param {boolean} [selection.isBackwards] Whether the focus is before the
anchor in document order
*/
--
To view, visit https://gerrit.wikimedia.org/r/257875
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I6b787fcc3d6e7db2876f2a8d463125d4b8190644
Gerrit-PatchSet: 1
Gerrit-Project: VisualEditor/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Esanders <[email protected]>
Gerrit-Reviewer: DLynch <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
