Esanders has uploaded a new change for review.
https://gerrit.wikimedia.org/r/257923
Change subject: Fix typos
......................................................................
Fix typos
Add some common ones to typos.json
Change-Id: I3830be4949ab6a5fd998d6937ed83e9f18091c2b
---
M build/typos.json
M modules/ve-mw/ce/nodes/ve.ce.MWAlienExtensionNode.js
M modules/ve-mw/ce/nodes/ve.ce.MWImageNode.js
M modules/ve-mw/ce/nodes/ve.ce.MWReferencesListNode.js
M modules/ve-mw/dm/models/ve.dm.MWImageModel.js
M modules/ve-mw/dm/models/ve.dm.MWTemplateModel.js
M modules/ve-mw/dm/models/ve.dm.MWTemplateSpecModel.js
M modules/ve-mw/dm/models/ve.dm.MWTransclusionModel.js
M modules/ve-mw/dm/nodes/ve.dm.MWBlockImageNode.js
M modules/ve-mw/dm/nodes/ve.dm.MWEntityNode.js
M modules/ve-mw/dm/nodes/ve.dm.MWReferenceNode.js
M modules/ve-mw/init/targets/ve.init.mw.DesktopArticleTarget.js
M modules/ve-mw/init/ve.init.mw.Target.js
M modules/ve-mw/init/ve.init.mw.TargetEvents.js
M modules/ve-mw/tests/dm/ve.dm.mwExample.js
M modules/ve-mw/ui/dialogs/ve.ui.MWMediaDialog.js
M modules/ve-mw/ui/styles/dialogs/ve.ui.MWMediaDialog.css
M modules/ve-mw/ui/widgets/ve.ui.MWMediaSearchWidget.js
M modules/ve-mw/ui/widgets/ve.ui.MWParameterSearchWidget.js
M modules/ve-mw/ui/widgets/ve.ui.MWTocWidget.js
20 files changed, 32 insertions(+), 29 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/VisualEditor
refs/changes/23/257923/1
diff --git a/build/typos.json b/build/typos.json
index b9a8e62..34a48ed 100644
--- a/build/typos.json
+++ b/build/typos.json
@@ -11,6 +11,9 @@
[ "contian", "contain" ],
[ "occured", "occurred" ],
[ "pgk", "pkg" ],
- [ "arrray", "array" ]
+ [ "arrray", "array" ],
+ [ "overriden", "overridden" ],
+ [ "begining", "beginning" ],
+ [ "detatched", "detached" ]
]
}
diff --git a/modules/ve-mw/ce/nodes/ve.ce.MWAlienExtensionNode.js
b/modules/ve-mw/ce/nodes/ve.ce.MWAlienExtensionNode.js
index 6ca8faf..8d962d3 100644
--- a/modules/ve-mw/ce/nodes/ve.ce.MWAlienExtensionNode.js
+++ b/modules/ve-mw/ce/nodes/ve.ce.MWAlienExtensionNode.js
@@ -51,7 +51,7 @@
* @inheritdoc ve.ce.MWExtensionNode
*/
ve.ce.MWAlienExtensionNode.prototype.render = function ( generatedContents ) {
- // Since render is trigerred before onSetup, we need to make sure that
the
+ // Since render is triggered before onSetup, we need to make sure that
the
// icon is detached only when it is defined and is not null
if ( this.$icon ) {
this.$icon.detach();
diff --git a/modules/ve-mw/ce/nodes/ve.ce.MWImageNode.js
b/modules/ve-mw/ce/nodes/ve.ce.MWImageNode.js
index bf3e216..af9182e 100644
--- a/modules/ve-mw/ce/nodes/ve.ce.MWImageNode.js
+++ b/modules/ve-mw/ce/nodes/ve.ce.MWImageNode.js
@@ -28,7 +28,7 @@
// Properties
this.$figure = $figure;
this.$image = $image;
- // Parent constructor triggers render so this must preceed it
+ // Parent constructor triggers render so this must precede it
this.renderedDimensions = null;
// Parent constructor
@@ -129,7 +129,7 @@
/** */
ve.ce.MWImageNode.prototype.render = function ( generatedContents ) {
this.$image.attr( 'src', generatedContents );
- // As we only re-render when the image is larger than last renedered
size
+ // As we only re-render when the image is larger than last rendered size
// this will always be the largest ever rendering
this.renderedDimensions = ve.copy(
this.model.getScalable().getCurrentDimensions() );
if ( this.live ) {
diff --git a/modules/ve-mw/ce/nodes/ve.ce.MWReferencesListNode.js
b/modules/ve-mw/ce/nodes/ve.ce.MWReferencesListNode.js
index 306d4b2..00089ad 100644
--- a/modules/ve-mw/ce/nodes/ve.ce.MWReferencesListNode.js
+++ b/modules/ve-mw/ce/nodes/ve.ce.MWReferencesListNode.js
@@ -240,7 +240,7 @@
.append( viewNode.$element )
);
// HACK: See bug 62682 - We happen to know that
destroy doesn't abort async
- // rendering for generated content nodes, but
we really can't gaurantee that in the
+ // rendering for generated content nodes, but
we really can't guarantee that in the
// future - if you are here, debugging, because
something isn't rendering properly,
// it's likely that something has changed and
these assumptions are no longer valid
viewNode.destroy();
diff --git a/modules/ve-mw/dm/models/ve.dm.MWImageModel.js
b/modules/ve-mw/dm/models/ve.dm.MWImageModel.js
index 0c12819..175a2eb 100644
--- a/modules/ve-mw/dm/models/ve.dm.MWImageModel.js
+++ b/modules/ve-mw/dm/models/ve.dm.MWImageModel.js
@@ -320,7 +320,7 @@
} else {
// Call for updated scalable if we don't have dimensions from
the API info
if ( this.getFilename() ) {
- // Update anyways
+ // Update anyway
ve.dm.MWImageNode.static.getScalablePromise(
this.getFilename() ).done( function ( info ) {
imageModel.scalable.setOriginalDimensions( {
width: info.width,
@@ -691,7 +691,7 @@
defaultAlignment = ( this.parentDoc.getDir() === 'rtl' ) ?
'left' : 'right';
imageType = imageType || this.getType();
- // No alignment specified means defeault alignment always
+ // No alignment specified means default alignment always
// Inline images have no align attribute; during the initialization
// stage of the model we have to account for that option. Later the
// model creates a faux alignment for inline images ('none' for default)
@@ -938,7 +938,7 @@
this.type = type;
- // If we're switching between inline and block or vise versa,
+ // If we're switching between inline and block or vice versa,
// check if the old type image was default aligned
if ( isDefaultAligned && this.imageCurrentType !== this.type ) {
if ( this.type === 'none' || this.type === 'frameless' ) {
diff --git a/modules/ve-mw/dm/models/ve.dm.MWTemplateModel.js
b/modules/ve-mw/dm/models/ve.dm.MWTemplateModel.js
index 8e440a3..2b73c40 100644
--- a/modules/ve-mw/dm/models/ve.dm.MWTemplateModel.js
+++ b/modules/ve-mw/dm/models/ve.dm.MWTemplateModel.js
@@ -185,7 +185,7 @@
/**
* Get ordered list of parameter names.
*
- * Numeric names, whether strings or real numbers, are placed at the begining,
followed by
+ * Numeric names, whether strings or real numbers, are placed at the
beginning, followed by
* alphabetically sorted names.
*
* @return {string[]} List of parameter names
diff --git a/modules/ve-mw/dm/models/ve.dm.MWTemplateSpecModel.js
b/modules/ve-mw/dm/models/ve.dm.MWTemplateSpecModel.js
index 5857ab3..ea1982e 100644
--- a/modules/ve-mw/dm/models/ve.dm.MWTemplateSpecModel.js
+++ b/modules/ve-mw/dm/models/ve.dm.MWTemplateSpecModel.js
@@ -79,7 +79,7 @@
/**
* Fill from template.
*
- * Filling is passive, so existing information is never overwitten. The spec
should be re-filled
+ * Filling is passive, so existing information is never overwritten. The spec
should be re-filled
* after a parameter is added to ensure it's still complete, and this is safe
because existing data
* is never overwritten.
*/
@@ -276,7 +276,7 @@
};
/**
- * Check if parameter is suggsted.
+ * Check if parameter is suggested.
*
* @param {string} name Parameter name
* @return {boolean} Parameter is suggested
diff --git a/modules/ve-mw/dm/models/ve.dm.MWTransclusionModel.js
b/modules/ve-mw/dm/models/ve.dm.MWTransclusionModel.js
index 2d636a9..abd184f 100644
--- a/modules/ve-mw/dm/models/ve.dm.MWTransclusionModel.js
+++ b/modules/ve-mw/dm/models/ve.dm.MWTransclusionModel.js
@@ -360,7 +360,7 @@
/**
* Replace part.
*
- * Replace asynchonously.
+ * Replace asynchronously.
*
* @param {ve.dm.MWTransclusionPartModel} remove Part to remove
* @param {ve.dm.MWTransclusionPartModel} add Part to add
diff --git a/modules/ve-mw/dm/nodes/ve.dm.MWBlockImageNode.js
b/modules/ve-mw/dm/nodes/ve.dm.MWBlockImageNode.js
index 52a94bf..ccd0972 100644
--- a/modules/ve-mw/dm/nodes/ve.dm.MWBlockImageNode.js
+++ b/modules/ve-mw/dm/nodes/ve.dm.MWBlockImageNode.js
@@ -133,7 +133,7 @@
attributes.type === 'thumb' ||
attributes.type === 'frameless'
) {
- // We're gonna change .width and .height, store the
original
+ // We're going to change .width and .height, store the
original
// values so we can restore them later.
// FIXME "just" don't modify .width and .height instead
attributes.originalWidth = attributes.width;
diff --git a/modules/ve-mw/dm/nodes/ve.dm.MWEntityNode.js
b/modules/ve-mw/dm/nodes/ve.dm.MWEntityNode.js
index 37651ce..f414ae9 100644
--- a/modules/ve-mw/dm/nodes/ve.dm.MWEntityNode.js
+++ b/modules/ve-mw/dm/nodes/ve.dm.MWEntityNode.js
@@ -6,7 +6,7 @@
*/
/**
- * DataModel MediaWiki entitiy node.
+ * DataModel MediaWiki entity node.
*
* @class
* @extends ve.dm.LeafNode
diff --git a/modules/ve-mw/dm/nodes/ve.dm.MWReferenceNode.js
b/modules/ve-mw/dm/nodes/ve.dm.MWReferenceNode.js
index 08d5362..2d7695c 100644
--- a/modules/ve-mw/dm/nodes/ve.dm.MWReferenceNode.js
+++ b/modules/ve-mw/dm/nodes/ve.dm.MWReferenceNode.js
@@ -351,7 +351,7 @@
};
/**
- * Handle the node being detatched from the root
+ * Handle the node being detached from the root
*/
ve.dm.MWReferenceNode.prototype.onUnroot = function () {
this.removeFromInternalList();
diff --git a/modules/ve-mw/init/targets/ve.init.mw.DesktopArticleTarget.js
b/modules/ve-mw/init/targets/ve.init.mw.DesktopArticleTarget.js
index 234867b..bf80d0c 100644
--- a/modules/ve-mw/init/targets/ve.init.mw.DesktopArticleTarget.js
+++ b/modules/ve-mw/init/targets/ve.init.mw.DesktopArticleTarget.js
@@ -321,7 +321,7 @@
/**
* Handle the watch button being toggled on/off.
*
- * @param {jQuery.Event} e Event object whih triggered the event
+ * @param {jQuery.Event} e Event object which triggered the event
* @param {string} actionPerformed 'watch' or 'unwatch'
*/
ve.init.mw.DesktopArticleTarget.prototype.onWatchToggle = function ( e,
actionPerformed ) {
diff --git a/modules/ve-mw/init/ve.init.mw.Target.js
b/modules/ve-mw/init/ve.init.mw.Target.js
index 0c200fd..1ef4fe4 100644
--- a/modules/ve-mw/init/ve.init.mw.Target.js
+++ b/modules/ve-mw/init/ve.init.mw.Target.js
@@ -553,7 +553,7 @@
if (
( isAnon && userInfo.anon !==
undefined ) ||
- // Comparing id instead
of name to pretect against possible
+ // Comparing id instead
of name to protect against possible
// normalisation and
against case where the user got renamed.
mw.config.get(
'wgUserId' ) === userInfo.id
) {
@@ -1029,7 +1029,7 @@
* Add reference insertion tools from on-wiki data.
*
* By adding a definition in JSON to
MediaWiki:Visualeditor-cite-tool-definition, the cite menu can
- * be populated with tools that create refrences containing a specific
templates. The content of the
+ * be populated with tools that create references containing a specific
templates. The content of the
* definition should be an array containing a series of objects, one for each
tool. Each object must
* contain a `name`, `icon` and `template` property. An optional `title`
property can also be used
* to define the tool title in plain text. The `name` property is a unique
identifier for the tool,
diff --git a/modules/ve-mw/init/ve.init.mw.TargetEvents.js
b/modules/ve-mw/init/ve.init.mw.TargetEvents.js
index 2cdd089..4d5e395 100644
--- a/modules/ve-mw/init/ve.init.mw.TargetEvents.js
+++ b/modules/ve-mw/init/ve.init.mw.TargetEvents.js
@@ -20,7 +20,7 @@
this.target.connect( this, {
saveWorkflowBegin: 'onSaveWorkflowBegin',
saveWorkflowEnd: 'onSaveWorkflowEnd',
- saveInitiated: 'onSaveInitated',
+ saveInitiated: 'onSaveInitiated',
save: 'onSaveComplete',
saveReview: 'onSaveReview',
saveErrorEmpty: [ 'trackSaveError', 'empty' ],
@@ -80,7 +80,7 @@
/**
* Track when document save is initiated
*/
-ve.init.mw.TargetEvents.prototype.onSaveInitated = function () {
+ve.init.mw.TargetEvents.prototype.onSaveInitiated = function () {
this.timings.saveInitiated = ve.now();
this.timings.saveRetries++;
this.track( 'behavior.saveDialogOpenTillSave', {
@@ -216,14 +216,14 @@
};
/**
- * Track whe serilization is complete in review workflow
+ * Track when serialization is complete in review workflow
*/
ve.init.mw.TargetEvents.prototype.onSerializeComplete = function () {
this.track( 'performance.user.reviewComplete', { duration: ve.now() -
this.timings.saveReview } );
};
/**
- * Track when there is a serlization error
+ * Track when there is a serialization error
*/
ve.init.mw.TargetEvents.prototype.onSerializeError = function () {
if ( this.timings.saveWorkflowBegin ) {
diff --git a/modules/ve-mw/tests/dm/ve.dm.mwExample.js
b/modules/ve-mw/tests/dm/ve.dm.mwExample.js
index 732c07e..301fe04 100644
--- a/modules/ve-mw/tests/dm/ve.dm.mwExample.js
+++ b/modules/ve-mw/tests/dm/ve.dm.mwExample.js
@@ -638,7 +638,7 @@
{ type: '/paragraph' },
{
type: 'mwReferencesList',
- // orginalDomElements: HTML,
+ // originalDomElements: HTML,
attributes: {
mw: {
name: 'references',
diff --git a/modules/ve-mw/ui/dialogs/ve.ui.MWMediaDialog.js
b/modules/ve-mw/ui/dialogs/ve.ui.MWMediaDialog.js
index df2cab1..41a0b21 100644
--- a/modules/ve-mw/ui/dialogs/ve.ui.MWMediaDialog.js
+++ b/modules/ve-mw/ui/dialogs/ve.ui.MWMediaDialog.js
@@ -236,7 +236,7 @@
label: ve.msg( 'visualeditor-dialog-media-content-section' ),
help: ve.msg( 'visualeditor-dialog-media-content-section-help'
),
icon: 'parameter',
- classes: [ 've-ui-mwMediaDialog-caption-fielset' ]
+ classes: [ 've-ui-mwMediaDialog-caption-fieldset' ]
} );
// Alt text
@@ -1373,7 +1373,7 @@
if (
// There was an initial node
this.selectedNode &&
- // And we didn't change the image type
block/inline or vise versa
+ // And we didn't change the image type
block/inline or vice versa
this.selectedNode.type ===
this.imageModel.getImageNodeType() &&
// And we didn't change the image itself
this.selectedNode.getAttribute( 'src' )
===
diff --git a/modules/ve-mw/ui/styles/dialogs/ve.ui.MWMediaDialog.css
b/modules/ve-mw/ui/styles/dialogs/ve.ui.MWMediaDialog.css
index 49a34ed..3e08b7f 100644
--- a/modules/ve-mw/ui/styles/dialogs/ve.ui.MWMediaDialog.css
+++ b/modules/ve-mw/ui/styles/dialogs/ve.ui.MWMediaDialog.css
@@ -69,7 +69,7 @@
}
/* HACK: Override ooui specific 2em top margin */
-.ve-ui-mwMediaDialog-caption-fielset.oo-ui-labelElement.oo-ui-fieldsetLayout {
+.ve-ui-mwMediaDialog-caption-fieldset.oo-ui-labelElement.oo-ui-fieldsetLayout {
margin-top: 0;
}
diff --git a/modules/ve-mw/ui/widgets/ve.ui.MWMediaSearchWidget.js
b/modules/ve-mw/ui/widgets/ve.ui.MWMediaSearchWidget.js
index 4e9fb08..10cd735 100644
--- a/modules/ve-mw/ui/widgets/ve.ui.MWMediaSearchWidget.js
+++ b/modules/ve-mw/ui/widgets/ve.ui.MWMediaSearchWidget.js
@@ -369,7 +369,7 @@
row = search.getAvailableRow();
}
- // Add the commulative
+ // Add the cumulative
search.rows[ row ].width += itemWidth;
// Store reference to the item and to the row
diff --git a/modules/ve-mw/ui/widgets/ve.ui.MWParameterSearchWidget.js
b/modules/ve-mw/ui/widgets/ve.ui.MWParameterSearchWidget.js
index 54552fe..6780703 100644
--- a/modules/ve-mw/ui/widgets/ve.ui.MWParameterSearchWidget.js
+++ b/modules/ve-mw/ui/widgets/ve.ui.MWParameterSearchWidget.js
@@ -87,7 +87,7 @@
};
/**
- * Build a serchable index of parameters.
+ * Build a searchable index of parameters.
*
* @method
* @param {ve.dm.MWTemplateSpecModel} spec Template specification
diff --git a/modules/ve-mw/ui/widgets/ve.ui.MWTocWidget.js
b/modules/ve-mw/ui/widgets/ve.ui.MWTocWidget.js
index 25cfc6a..a844ff5 100644
--- a/modules/ve-mw/ui/widgets/ve.ui.MWTocWidget.js
+++ b/modules/ve-mw/ui/widgets/ve.ui.MWTocWidget.js
@@ -111,7 +111,7 @@
};
/**
- * Initialize TOC based on the presense of magic words
+ * Initialize TOC based on the presence of magic words
*/
ve.ui.MWTocWidget.prototype.initFromMetaList = function () {
var i = 0,
--
To view, visit https://gerrit.wikimedia.org/r/257923
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I3830be4949ab6a5fd998d6937ed83e9f18091c2b
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Esanders <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
