JGirault has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/258064

Change subject: Fixes Chrome-specific bug.
......................................................................

Fixes Chrome-specific bug.

Some versions of Chrome fail when rendering <input autofocus>.
They seem to be fine with <input autofocus="autofocus">.

Bug: T120795
Change-Id: Idd15b68d76e14bd3607510f143204155c5201721
---
M gulpfile.js
M prod/wikipedia.org/index.html
2 files changed, 4 insertions(+), 4 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/wikimedia/portals 
refs/changes/64/258064/1

diff --git a/gulpfile.js b/gulpfile.js
index b592fde..59d91a4 100644
--- a/gulpfile.js
+++ b/gulpfile.js
@@ -90,7 +90,7 @@
                        preventAttributesEscaping: true,
                        collapseWhitespace: true,
                        preserveLineBreaks: true,
-                       collapseBooleanAttributes: true
+                       collapseBooleanAttributes: false
                }
        };
 
diff --git a/prod/wikipedia.org/index.html b/prod/wikipedia.org/index.html
index 16f4263..a45509b 100644
--- a/prod/wikipedia.org/index.html
+++ b/prod/wikipedia.org/index.html
@@ -124,7 +124,7 @@
 <option value="de" lang="de">Deutsch</option>
 <option value="et" lang="et">Eesti</option>
 <option value="el" lang="el">Ελληνικά</option><!-- Ellīniká -->
-<option value="en" lang="en" selected>English</option>
+<option value="en" lang="en" selected=selected>English</option>
 <option value="es" lang="es">Español</option>
 <option value="eo" lang="eo">Esperanto</option>
 <option value="eu" lang="eu">Euskara</option>
@@ -170,7 +170,7 @@
 <option value="war" lang="war">Winaray</option>
 <option value="zh" lang="zh">中文</option><!-- Zhōngwén -->
 </select>
-<input id="searchInput" name="search" type="search" size="20" autofocus 
accesskey="F" dir="auto">
+<input id="searchInput" name="search" type="search" size="20" 
autofocus="autofocus" accesskey="F" dir="auto">
 <button class="formBtn" type="submit" name="go"><img 
src="portal/wikipedia.org/assets/img/12px-Vector_search_icon.svg.png" 
srcset="portal/wikipedia.org/assets/img/18px-Vector_search_icon.svg.png 1.5x, 
portal/wikipedia.org/assets/img/24px-Vector_search_icon.svg.png 2x" 
alt="Search"></button>
 <input type="hidden" value="Go" name="go">
 </fieldset>
@@ -186,7 +186,7 @@
 <input type="hidden" name="family" value="wikipedia">
 <input type="hidden" id="hiddenLanguageInput" name="language" value="en">
 <div class="search-input">
-<input id="searchInput" name="search" type="search" size="20" autofocus 
accesskey="F" dir="auto" results="10" autocomplete="off" list="suggestions">
+<input id="searchInput" name="search" type="search" size="20" 
autofocus="autofocus" accesskey="F" dir="auto" results="10" autocomplete="off" 
list="suggestions">
 <a class="language-picker" tabindex="-1" href="javascript:void 0"><span 
id="selectedLanguageCode">EN</span> <i class="icon-caret-down"></i></a>
 <ul id="searchLanguage">
 <!-- 100,000+ content pages, sorted by romanization -->

-- 
To view, visit https://gerrit.wikimedia.org/r/258064
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Idd15b68d76e14bd3607510f143204155c5201721
Gerrit-PatchSet: 1
Gerrit-Project: wikimedia/portals
Gerrit-Branch: master
Gerrit-Owner: JGirault <[email protected]>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to