Jdlrobson has uploaded a new change for review.
https://gerrit.wikimedia.org/r/258078
Change subject: WIP: Use hooks to control RelatedArticles during VisualEditor
experience
......................................................................
WIP: Use hooks to control RelatedArticles during VisualEditor experience
Upstram changes needed...
Change-Id: Ia0b1b1e3664bd43d2b22ce4b55b6e9c3ab345d0f
---
M resources/ext.relatedArticles.readMore/index.js
M resources/ext.relatedArticles.readMore/readMore.less
2 files changed, 11 insertions(+), 7 deletions(-)
git pull
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/RelatedArticles
refs/changes/78/258078/1
diff --git a/resources/ext.relatedArticles.readMore/index.js
b/resources/ext.relatedArticles.readMore/index.js
index bc83d6e..152f4d5 100644
--- a/resources/ext.relatedArticles.readMore/index.js
+++ b/resources/ext.relatedArticles.readMore/index.js
@@ -52,6 +52,17 @@
// the ReadMore code is ready
mw.track( 'ext.relatedArticles.logReady', { $readMore:
$readMore } );
+
+ // IF VisualEditor is installed remove on edit
+ // FIXME: Ideally should run on clicking edit
+ mw.hook('ve.activate' ).add( function () {
+ $readMore.detach();
+ } );
+ // FIXME: This should run after the content has been
appended to the document but it doesn't.
+ // No hook to append after content has rendered.
+ mw.hook('postEdit' ).add( function () {
+ $( '#content' ).append( $readMore );
+ } );
} );
} );
diff --git a/resources/ext.relatedArticles.readMore/readMore.less
b/resources/ext.relatedArticles.readMore/readMore.less
index d4dcde1..001f4c7 100644
--- a/resources/ext.relatedArticles.readMore/readMore.less
+++ b/resources/ext.relatedArticles.readMore/readMore.less
@@ -1,12 +1,5 @@
@import "mediawiki.ui/variables";
-// Hide RelatedArticles when VE is activated
(https://phabricator.wikimedia.org/T120443)
-.ve-activated {
- .ra-read-more {
- display: none;
- }
-}
-
.ra-read-more {
margin-top: 35px;
margin-bottom: 70px;
--
To view, visit https://gerrit.wikimedia.org/r/258078
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia0b1b1e3664bd43d2b22ce4b55b6e9c3ab345d0f
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/RelatedArticles
Gerrit-Branch: dev
Gerrit-Owner: Jdlrobson <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
