jenkins-bot has submitted this change and it was merged.
Change subject: Remove deprecated "tipsy" tooltip CSS
......................................................................
Remove deprecated "tipsy" tooltip CSS
The deprecated code is no longer needed. Be aware that this patch will
change all our blue tooltip windows to white. PM said yes to this change.
The red error tooltips will stay red.
The arrow was made invisible in I095d9b0. I could not find a reason why
this was done. Most probably because of the bug I'm now fixing with the
additional "top: 0". Also see I560d501.
Change-Id: Ifb0b9d8d4174a7701df021f729f48dd298d67c5c
---
D lib/resources/jquery.wikibase/themes/default/images/tipsy.png
M lib/resources/jquery.wikibase/themes/default/jquery.wikibase.wbtooltip.css
M view/resources/wikibase/wikibase.css
3 files changed, 4 insertions(+), 19 deletions(-)
Approvals:
Bene: Looks good to me, approved
jenkins-bot: Verified
diff --git a/lib/resources/jquery.wikibase/themes/default/images/tipsy.png
b/lib/resources/jquery.wikibase/themes/default/images/tipsy.png
deleted file mode 100644
index 3aa168e..0000000
--- a/lib/resources/jquery.wikibase/themes/default/images/tipsy.png
+++ /dev/null
Binary files differ
diff --git
a/lib/resources/jquery.wikibase/themes/default/jquery.wikibase.wbtooltip.css
b/lib/resources/jquery.wikibase/themes/default/jquery.wikibase.wbtooltip.css
index 47bee02..0b51863 100644
--- a/lib/resources/jquery.wikibase/themes/default/jquery.wikibase.wbtooltip.css
+++ b/lib/resources/jquery.wikibase/themes/default/jquery.wikibase.wbtooltip.css
@@ -5,20 +5,11 @@
* @author H. Snater < mediaw...@snater.com >
*/
-/* FIXME: We can remove the following two blocks and delete the image 30 days
after the outdated
-tipsy styles in shared.css are removed and we want to remove the blue color
from our tooltips. */
-.wikibase-wbtooltip-tip .tipsy-inner {
- background-color: #d6f3ff;
- border-color: #5dc9f4;
+/* FIXME: Remove when core's jquery.tipsy.css is fixed. */
+.wikibase-wbtooltip-tip.tipsy-nw .tipsy-arrow,
+.wikibase-wbtooltip-tip.tipsy-ne .tipsy-arrow {
+ top: 0;
}
-.wikibase-wbtooltip-tip .tipsy-arrow {
- /* @embed */
- background-image: url(images/tipsy.png);
- /* FIXME: Remove 30 days after the outdated tipsy-arrow style in
shared.css is removed */
- height: 6px;
-}
-
-/***** ERROR TOOLTIP *****/
.wikibase-wbtooltip-tip.wb-error .tipsy-arrow {
/* @embed */
@@ -32,5 +23,3 @@
background: #FFDFC9;
border-color: #B27631;
}
-
-/***** /ERROR TOOLTIP *****/
diff --git a/view/resources/wikibase/wikibase.css
b/view/resources/wikibase/wikibase.css
index 54bccd4..01a5753 100644
--- a/view/resources/wikibase/wikibase.css
+++ b/view/resources/wikibase/wikibase.css
@@ -43,10 +43,6 @@
color: inherit;
}
-.wb-entitypage .wikibase-wbtooltip-tip .tipsy-arrow {
- display: none;
-}
-
/* Messages displayed while some action is performed (e.g. an API call) */
.wb-actionmsg {
font-style: italic;
--
To view, visit https://gerrit.wikimedia.org/r/253937
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ifb0b9d8d4174a7701df021f729f48dd298d67c5c
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Thiemo Mättig (WMDE) <thiemo.maet...@wikimedia.de>
Gerrit-Reviewer: Adrian Lang <adrian.he...@wikimedia.de>
Gerrit-Reviewer: Bene <benestar.wikime...@gmail.com>
Gerrit-Reviewer: Hoo man <h...@online.de>
Gerrit-Reviewer: Jonas Kress (WMDE) <jonas.kr...@wikimedia.de>
Gerrit-Reviewer: Thiemo Mättig (WMDE) <thiemo.maet...@wikimedia.de>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
