Santhosh has uploaded a new change for review.
https://gerrit.wikimedia.org/r/258127
Change subject: Suggestions: Use flexbox to align action items in middle
......................................................................
Suggestions: Use flexbox to align action items in middle
Change-Id: I538d71c9ca1cdcaf2222a94b9b98eddb9e38bd50
Followup: I2a11ecb206be6b63349a76d0b5c026d1c6b8eeed
---
M modules/dashboard/ext.cx.suggestionlist.js
M modules/dashboard/styles/ext.cx.suggestionlist.less
2 files changed, 6 insertions(+), 3 deletions(-)
git pull
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/ContentTranslation
refs/changes/27/258127/1
diff --git a/modules/dashboard/ext.cx.suggestionlist.js
b/modules/dashboard/ext.cx.suggestionlist.js
index 638f203..8c01be5 100644
--- a/modules/dashboard/ext.cx.suggestionlist.js
+++ b/modules/dashboard/ext.cx.suggestionlist.js
@@ -501,7 +501,7 @@
.append( $translationLink, $desc, $metaDataContainer );
$actions = $( '<div>' )
.addClass( 'cx-slitem__actions' )
- .append( $discardAction, $favoriteAction );
+ .append( $favoriteAction, $discardAction );
$suggestion.append(
$image,
$titleLanguageBlock,
diff --git a/modules/dashboard/styles/ext.cx.suggestionlist.less
b/modules/dashboard/styles/ext.cx.suggestionlist.less
index ee90f80..1a75d54 100644
--- a/modules/dashboard/styles/ext.cx.suggestionlist.less
+++ b/modules/dashboard/styles/ext.cx.suggestionlist.less
@@ -97,8 +97,11 @@
.cx-slitem__actions {
.mw-ui-one-sixth;
float: right;
- position: relative;
- padding-top: 90px/2 - 30px/2;
+ min-height: 90px;
+ /* In supported browsers, center it */
+ display: flex;
+ justify-content: center; /* align horizontally */
+ align-items: center; /* align vertically */
}
.cx-slitem__action {
--
To view, visit https://gerrit.wikimedia.org/r/258127
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I538d71c9ca1cdcaf2222a94b9b98eddb9e38bd50
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/ContentTranslation
Gerrit-Branch: master
Gerrit-Owner: Santhosh <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
