jenkins-bot has submitted this change and it was merged.
Change subject: Disable RelatedArticles when editor enabled
......................................................................
Disable RelatedArticles when editor enabled
We only want to show it in view mode.
When a reader hits edit, wgAction is view so we add a CSS rule to
hide the widget when that transition occurs.
This means related widget does not show up post edit (you'll need to
refresh but this seems like an acceptable workaround until we can
understand this issue some more)
Bug: T120443
Bug: T120735
Change-Id: If1356906d5f55167c9d1abbed88f433f36b7f390
---
M resources/ext.relatedArticles.readMore.bootstrap/index.js
M resources/ext.relatedArticles.readMore/readMore.less
2 files changed, 9 insertions(+), 0 deletions(-)
Approvals:
Catrope: Looks good to me, approved
jenkins-bot: Verified
diff --git a/resources/ext.relatedArticles.readMore.bootstrap/index.js
b/resources/ext.relatedArticles.readMore.bootstrap/index.js
index 4a769a2..edaa342 100644
--- a/resources/ext.relatedArticles.readMore.bootstrap/index.js
+++ b/resources/ext.relatedArticles.readMore.bootstrap/index.js
@@ -38,6 +38,8 @@
if (
config.wgNamespaceNumber === 0 &&
!config.wgIsMainPage &&
+ // T120735
+ mw.config.get( 'wgAction' ) === 'view' &&
// any skin except minerva stable
( config.skin !== 'minerva' || config.wgMFMode === 'beta' )
) {
diff --git a/resources/ext.relatedArticles.readMore/readMore.less
b/resources/ext.relatedArticles.readMore/readMore.less
index 001f4c7..d4dcde1 100644
--- a/resources/ext.relatedArticles.readMore/readMore.less
+++ b/resources/ext.relatedArticles.readMore/readMore.less
@@ -1,5 +1,12 @@
@import "mediawiki.ui/variables";
+// Hide RelatedArticles when VE is activated
(https://phabricator.wikimedia.org/T120443)
+.ve-activated {
+ .ra-read-more {
+ display: none;
+ }
+}
+
.ra-read-more {
margin-top: 35px;
margin-bottom: 70px;
--
To view, visit https://gerrit.wikimedia.org/r/258062
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: If1356906d5f55167c9d1abbed88f433f36b7f390
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/extensions/RelatedArticles
Gerrit-Branch: wmf/1.27.0-wmf.8
Gerrit-Owner: Jdlrobson <[email protected]>
Gerrit-Reviewer: Catrope <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
