Lucie Kaffee has uploaded a new change for review.
https://gerrit.wikimedia.org/r/258451
Change subject: Implement feedback from the security review
......................................................................
Implement feedback from the security review
Bug: T118268
Change-Id: I8f896141742c3917a067ce149a58f190df2371a8
---
M Specials/SpecialAboutTopic.php
1 file changed, 2 insertions(+), 2 deletions(-)
git pull
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/ArticlePlaceholder
refs/changes/51/258451/1
diff --git a/Specials/SpecialAboutTopic.php b/Specials/SpecialAboutTopic.php
index dc342b6..a650e98 100644
--- a/Specials/SpecialAboutTopic.php
+++ b/Specials/SpecialAboutTopic.php
@@ -100,7 +100,7 @@
* @param string $sub
*/
public function execute( $sub ) {
- $this->getOutput()->setPageTitle( $this->msg(
'articleplaceholder-abouttopic' ) );
+ $this->getOutput()->setPageTitle( $this->msg(
'articleplaceholder-abouttopic' )->escaped() );
$this->showContent( $sub );
}
@@ -277,7 +277,7 @@
->getLabel( $entityId );
if ( $label !== null ) {
- return $label->getText();
+ return htmlspecialchars( $label->getText() );
}
return null;
--
To view, visit https://gerrit.wikimedia.org/r/258451
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I8f896141742c3917a067ce149a58f190df2371a8
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/ArticlePlaceholder
Gerrit-Branch: master
Gerrit-Owner: Lucie Kaffee <lucie.kaf...@wikimedia.de>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
