jenkins-bot has submitted this change and it was merged.
Change subject: DesktopArticleTarget: Fix signature of editNotices
......................................................................
DesktopArticleTarget: Fix signature of editNotices
Also ensure it is always an array.
Change-Id: I8498463d3131817b90fa91404289c839110bdeaa
---
M modules/ve-mw/init/ve.init.mw.ArticleTarget.js
1 file changed, 2 insertions(+), 2 deletions(-)
Approvals:
Jforrester: Looks good to me, approved
jenkins-bot: Verified
diff --git a/modules/ve-mw/init/ve.init.mw.ArticleTarget.js
b/modules/ve-mw/init/ve.init.mw.ArticleTarget.js
index 35a0e61..33ebc1f 100644
--- a/modules/ve-mw/init/ve.init.mw.ArticleTarget.js
+++ b/modules/ve-mw/init/ve.init.mw.ArticleTarget.js
@@ -1215,7 +1215,7 @@
this.startTimeStamp = null;
this.doc = null;
this.originalHtml = null;
- this.editNotices = null;
+ this.editNotices = [];
this.remoteNotices = [];
this.localNoticeMessages = [];
};
@@ -1661,7 +1661,7 @@
/**
* Get list of edit notices.
*
- * @return {Object|null} List of edit notices or null if none are loaded
+ * @return {Array} List of edit notices
*/
ve.init.mw.ArticleTarget.prototype.getEditNotices = function () {
return this.editNotices;
--
To view, visit https://gerrit.wikimedia.org/r/258470
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I8498463d3131817b90fa91404289c839110bdeaa
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Esanders <esand...@wikimedia.org>
Gerrit-Reviewer: Jforrester <jforres...@wikimedia.org>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
