Aaron Schulz has uploaded a new change for review.
https://gerrit.wikimedia.org/r/258640
Change subject: Check User::getId() in makeTestEdits.php
......................................................................
Check User::getId() in makeTestEdits.php
Change-Id: If803f1aea144f91dadf70e1a41d6834a2fd1d66e
---
M maintenance/makeTestEdits.php
M tests/phpunit/MediaWikiTestCase.php
2 files changed, 2 insertions(+), 1 deletion(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core
refs/changes/40/258640/1
diff --git a/maintenance/makeTestEdits.php b/maintenance/makeTestEdits.php
index fdf4eb9..c6569a0 100644
--- a/maintenance/makeTestEdits.php
+++ b/maintenance/makeTestEdits.php
@@ -39,7 +39,7 @@
public function execute() {
$user = User::newFromName( $this->getOption( 'user' ) );
- if ( !$user ) {
+ if ( !$user->getId() ) {
$this->error( "No such user exists.", 1 );
}
diff --git a/tests/phpunit/MediaWikiTestCase.php
b/tests/phpunit/MediaWikiTestCase.php
index 9e4a984..055e500 100644
--- a/tests/phpunit/MediaWikiTestCase.php
+++ b/tests/phpunit/MediaWikiTestCase.php
@@ -212,6 +212,7 @@
}
DeferredUpdates::clearPendingUpdates();
+ JobQueueGroup::destroySingletons();
ob_start( 'MediaWikiTestCase::wfResetOutputBuffersBarrier' );
}
--
To view, visit https://gerrit.wikimedia.org/r/258640
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: If803f1aea144f91dadf70e1a41d6834a2fd1d66e
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Aaron Schulz <asch...@wikimedia.org>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
