Ejegg has uploaded a new change for review.
https://gerrit.wikimedia.org/r/258717
Change subject: Update gulpfile, hush up jslint
......................................................................
Update gulpfile, hush up jslint
Needed to add number filter.
Change-Id: Ib384d1a1844307786c33b1ace3bde80f0f179777
---
M gulpfile.js
M src/components/boards/generic-board/generic-board.js
M src/components/widgets/totals-earned-chart/totals-earned-chart.js
3 files changed, 4 insertions(+), 1 deletion(-)
git pull ssh://gerrit.wikimedia.org:29418/wikimedia/fundraising/dash
refs/changes/17/258717/1
diff --git a/gulpfile.js b/gulpfile.js
index 1f367e0..a97a869 100644
--- a/gulpfile.js
+++ b/gulpfile.js
@@ -35,6 +35,7 @@
'components/boards/generic-board/generic-board',
'components/filters/filters',
'components/filters/dropdown-filter/dropdown-filter',
+ 'components/filters/number-filter/number-filter',
'components/filters/text-filter/text-filter',
'components/nav-bar/nav-bar',
'components/utils/date-pickers/date-pickers',
diff --git a/src/components/boards/generic-board/generic-board.js
b/src/components/boards/generic-board/generic-board.js
index 4a7066d..1bd0688 100644
--- a/src/components/boards/generic-board/generic-board.js
+++ b/src/components/boards/generic-board/generic-board.js
@@ -50,7 +50,7 @@
}
} );
$( '#loadingModal' ).on( 'hidden.bs.modal', function () {
- $( this ).css( "display", "none");
+ $( this ).css( 'display', 'none');
$( '.modal-backdrop' ).remove();
} );
// Get the date
diff --git a/src/components/widgets/totals-earned-chart/totals-earned-chart.js
b/src/components/widgets/totals-earned-chart/totals-earned-chart.js
index 275cbfc..547fabb 100644
--- a/src/components/widgets/totals-earned-chart/totals-earned-chart.js
+++ b/src/components/widgets/totals-earned-chart/totals-earned-chart.js
@@ -33,7 +33,9 @@
self.majorDonationCutoff = ko.observable(
self.config.majorDonationCutoff || 5000 ).extend( { throttle: 500 } );
self.year = ko.observable( self.config.year || new
Date().getFullYear() ).extend( { throttle: 500 } );
self.isCurrentYear = ko.computed( function() {
+ /*jslint -W116*/
return self.year() == new Date().getFullYear();
+ /*jslint -W116*/
} );
// FIXME: do this stuff on 'Submit', actually cancel changes on
'Cancel'
--
To view, visit https://gerrit.wikimedia.org/r/258717
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ib384d1a1844307786c33b1ace3bde80f0f179777
Gerrit-PatchSet: 1
Gerrit-Project: wikimedia/fundraising/dash
Gerrit-Branch: master
Gerrit-Owner: Ejegg <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
