Yuvipanda has uploaded a new change for review.
https://gerrit.wikimedia.org/r/258719
Change subject: diamond: Fix puppet failures on first run
......................................................................
diamond: Fix puppet failures on first run
Fix for:
Change-Id: I12a8cd2b2bd0ef828c19ab2655689cc2d15e8cd2
Error: Cannot create /usr/share/diamond/collectors/SSHSessions; parent
directory /usr/share/diamond/collectors does not exist
Error:
/Stage[main]/Role::Labs::Instance/Diamond::Collector[SSHSessions]/File[/usr/share/diamond/collectors/SSHSessions]/ensure:
change from absent to directory failed: Cannot create
/usr/share/diamond/collectors/SSHSessions; parent directory
/usr/share/diamond/collectors does not exist
Notice:
/Stage[main]/Role::Labs::Instance/Diamond::Collector[SSHSessions]/File[/usr/share/diamond/collectors/SSHSessions/SSHSessions.py]:
Dependency File[/usr/share/diamond/collectors/SSHSessions] has failures: true
Warning:
/Stage[main]/Role::Labs::Instance/Diamond::Collector[SSHSessions]/File[/usr/share/diamond/collectors/SSHSessions/SSHSessions.py]:
Skipping because of failed dependencies
---
M modules/diamond/manifests/collector.pp
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.wikimedia.org:29418/operations/puppet
refs/changes/19/258719/1
diff --git a/modules/diamond/manifests/collector.pp
b/modules/diamond/manifests/collector.pp
index 2698df5..08b40d6 100644
--- a/modules/diamond/manifests/collector.pp
+++ b/modules/diamond/manifests/collector.pp
@@ -64,7 +64,7 @@
) {
validate_ensure($ensure)
- include ::diamond
+ require ::diamond
$collector = regsubst($name, '(Collector)?$', 'Collector')
--
To view, visit https://gerrit.wikimedia.org/r/258719
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I12a8cd2b2bd0ef828c19ab2655689cc2d15e8cd2
Gerrit-PatchSet: 1
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Yuvipanda <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
