Santhosh has uploaded a new change for review.
https://gerrit.wikimedia.org/r/259638
Change subject: MT Card: Avoid having a dedicated element for clearfix
......................................................................
MT Card: Avoid having a dedicated element for clearfix
All tools cards have clearfix now.
Change-Id: I9636e6af82901ad2ef2fce37c510701fb684d44c
---
M modules/tools/ext.cx.tools.mt.js
M modules/tools/styles/ext.cx.tools.card.less
M modules/tools/styles/ext.cx.tools.mt.less
3 files changed, 10 insertions(+), 15 deletions(-)
git pull
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/ContentTranslation
refs/changes/38/259638/1
diff --git a/modules/tools/ext.cx.tools.mt.js b/modules/tools/ext.cx.tools.mt.js
index e71eecb..1d7164e 100644
--- a/modules/tools/ext.cx.tools.mt.js
+++ b/modules/tools/ext.cx.tools.mt.js
@@ -277,7 +277,7 @@
}
MTControlCard.prototype.getCard = function () {
- var $titleRow, $title, $controlButtonsBlock, $bottom;
+ var $titleRow, $title, $controlButtonsBlock;
this.$card = $( '<div>' )
.addClass( 'card mt' );
@@ -313,14 +313,10 @@
this.actions.$clear
);
- $bottom = $( '<div>' )
- .addClass( 'card__bottom' );
-
this.$card.append(
$titleRow,
this.$providerSelectorTrigger,
- $controlButtonsBlock,
- $bottom
+ $controlButtonsBlock
);
this.buildProvidersMenu();
diff --git a/modules/tools/styles/ext.cx.tools.card.less
b/modules/tools/styles/ext.cx.tools.card.less
index 2281b85..158b94c 100644
--- a/modules/tools/styles/ext.cx.tools.card.less
+++ b/modules/tools/styles/ext.cx.tools.card.less
@@ -11,6 +11,14 @@
border-color: #BBBBBB;
box-shadow: 0 1px 0 #BBBBBB;
}
+ /* Clearfix */
+ &:after {
+ content: " "; /* Older browser do not support empty content */
+ visibility: hidden;
+ display: block;
+ height: 0;
+ clear: both;
+ }
}
.card__title,
diff --git a/modules/tools/styles/ext.cx.tools.mt.less
b/modules/tools/styles/ext.cx.tools.mt.less
index 72af107..b174a08 100644
--- a/modules/tools/styles/ext.cx.tools.mt.less
+++ b/modules/tools/styles/ext.cx.tools.mt.less
@@ -130,13 +130,4 @@
border: none;
}
}
-
- .card__bottom {
- .mw-ui-item;
- .mw-ui-one-whole;
- float: none; // XXX why would it be needed?
- clear: both;
- padding: 5px;
- text-align: center;
- }
}
--
To view, visit https://gerrit.wikimedia.org/r/259638
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I9636e6af82901ad2ef2fce37c510701fb684d44c
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/ContentTranslation
Gerrit-Branch: master
Gerrit-Owner: Santhosh <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
