Thiemo Mättig (WMDE) has uploaded a new change for review.
https://gerrit.wikimedia.org/r/259651
Change subject: Fix camelCase of setUp calls
......................................................................
Fix camelCase of setUp calls
Change-Id: I3dc0106182c55b91c7e6dc07fc49c6410585e17e
---
M tests/phpunit/Api/RunCrossCheckTest.php
M tests/phpunit/UpdateExternalData/UpdateExternalDataTest.php
2 files changed, 6 insertions(+), 4 deletions(-)
git pull
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/WikibaseQualityExternalValidation
refs/changes/51/259651/1
diff --git a/tests/phpunit/Api/RunCrossCheckTest.php
b/tests/phpunit/Api/RunCrossCheckTest.php
index 2d5510f..3347625 100644
--- a/tests/phpunit/Api/RunCrossCheckTest.php
+++ b/tests/phpunit/Api/RunCrossCheckTest.php
@@ -63,8 +63,9 @@
/** @var bool */
private static $hasSetup;
- protected function setup() {
- parent::setup();
+ protected function setUp() {
+ parent::setUp();
+
$this->tablesUsed[] =
SqlDumpMetaInformationRepo::META_TABLE_NAME;
$this->tablesUsed[] =
SqlDumpMetaInformationRepo::IDENTIFIER_PROPERTIES_TABLE_NAME;
$this->tablesUsed[] = ExternalDataRepo::TABLE_NAME;
diff --git a/tests/phpunit/UpdateExternalData/UpdateExternalDataTest.php
b/tests/phpunit/UpdateExternalData/UpdateExternalDataTest.php
index 920ef61..ae9e5dd 100644
--- a/tests/phpunit/UpdateExternalData/UpdateExternalDataTest.php
+++ b/tests/phpunit/UpdateExternalData/UpdateExternalDataTest.php
@@ -23,8 +23,9 @@
*/
class UpdateExternalDataTest extends \MediaWikiTestCase {
- protected function setup() {
- parent::setup();
+ protected function setUp() {
+ parent::setUp();
+
$this->tablesUsed[] =
SqlDumpMetaInformationRepo::META_TABLE_NAME;
$this->tablesUsed[] = ExternalDataRepo::TABLE_NAME;
}
--
To view, visit https://gerrit.wikimedia.org/r/259651
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I3dc0106182c55b91c7e6dc07fc49c6410585e17e
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/WikibaseQualityExternalValidation
Gerrit-Branch: master
Gerrit-Owner: Thiemo Mättig (WMDE) <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits