Bartosz Dziewoński has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/259657

Change subject: Actually define tags for cross-wiki upload A/B test
......................................................................

Actually define tags for cross-wiki upload A/B test

Just cosmetics. This doesn't interfere with the test, but it's silly
when Special:Tags says the tags are 'no longer in use'.

Change-Id: I072fbca5dd8bdde0cf9f74364513048d887c327b
---
M WikimediaEventsHooks.php
1 file changed, 11 insertions(+), 0 deletions(-)


  git pull 
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/WikimediaEvents 
refs/changes/57/259657/1

diff --git a/WikimediaEventsHooks.php b/WikimediaEventsHooks.php
index fcc9341..95db985 100644
--- a/WikimediaEventsHooks.php
+++ b/WikimediaEventsHooks.php
@@ -391,6 +391,11 @@
                $tags[] = 'HHVM';
                if ( wfWikiId() === 'commonswiki' ) {
                        $tags[] = 'cross-wiki-upload';
+                       // For A/B test
+                       $tags[] = 'cross-wiki-upload-1';
+                       $tags[] = 'cross-wiki-upload-2';
+                       $tags[] = 'cross-wiki-upload-3';
+                       $tags[] = 'cross-wiki-upload-4';
                }
                return true;
        }
@@ -404,6 +409,11 @@
        public static function onChangeTagsListActive( &$tags ) {
                if ( wfWikiId() === 'commonswiki' ) {
                        $tags[] = 'cross-wiki-upload';
+                       // For A/B test
+                       $tags[] = 'cross-wiki-upload-1';
+                       $tags[] = 'cross-wiki-upload-2';
+                       $tags[] = 'cross-wiki-upload-3';
+                       $tags[] = 'cross-wiki-upload-4';
                }
                return true;
        }
@@ -440,6 +450,7 @@
                        return true;
                }
 
+               // A/B test
                $bucket = $request->getVal( 'bucket' );
                if ( !in_array( $bucket, array( '1', '2', '3', '4' ) ) ) {
                        $bucket = null;

-- 
To view, visit https://gerrit.wikimedia.org/r/259657
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I072fbca5dd8bdde0cf9f74364513048d887c327b
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/WikimediaEvents
Gerrit-Branch: master
Gerrit-Owner: Bartosz Dziewoński <[email protected]>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to