jenkins-bot has submitted this change and it was merged.
Change subject: Fix broken PHPDoc tags and prefer is_readable
......................................................................
Fix broken PHPDoc tags and prefer is_readable
The is_readable is what we do in most modules. This is for consistency.
The PHPDoc tags are actually broken and not recognized.
Change-Id: Ifcf85d00ac285356ab4959dab86eaf457efe71e9
---
M WikibaseQuality.php
M includes/Html/HtmlTableCellBuilder.php
M includes/Html/HtmlTableHeaderBuilder.php
3 files changed, 4 insertions(+), 3 deletions(-)
Approvals:
Aude: Looks good to me, approved
jenkins-bot: Verified
diff --git a/WikibaseQuality.php b/WikibaseQuality.php
index bf74ec7..83dc870 100644
--- a/WikibaseQuality.php
+++ b/WikibaseQuality.php
@@ -1,5 +1,6 @@
<?php
-if ( file_exists( __DIR__ . '/vendor/autoload.php' ) ) {
+
+if ( is_readable( __DIR__ . '/vendor/autoload.php' ) ) {
require_once __DIR__ . '/vendor/autoload.php';
}
diff --git a/includes/Html/HtmlTableCellBuilder.php
b/includes/Html/HtmlTableCellBuilder.php
index c840949..ec94779 100644
--- a/includes/Html/HtmlTableCellBuilder.php
+++ b/includes/Html/HtmlTableCellBuilder.php
@@ -32,7 +32,7 @@
private $isRawContent;
/**
- * @param string HTML $content
+ * @param string $content HTML
* @param array $attributes
* @param bool $isRawContent
*
diff --git a/includes/Html/HtmlTableHeaderBuilder.php
b/includes/Html/HtmlTableHeaderBuilder.php
index 6814278..ecef60a 100644
--- a/includes/Html/HtmlTableHeaderBuilder.php
+++ b/includes/Html/HtmlTableHeaderBuilder.php
@@ -34,7 +34,7 @@
private $isRawContent;
/**
- * @param string HTML $content
+ * @param string $content HTML
* @param bool $isSortable
* @param bool $isRawContent
*
--
To view, visit https://gerrit.wikimedia.org/r/259652
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ifcf85d00ac285356ab4959dab86eaf457efe71e9
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/WikibaseQuality
Gerrit-Branch: master
Gerrit-Owner: Thiemo Mättig (WMDE) <[email protected]>
Gerrit-Reviewer: Aude <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
