Zfilipin has uploaded a new change for review. https://gerrit.wikimedia.org/r/259708
Change subject: RuboCop: Fixed Style/DefWithParentheses offence ...................................................................... RuboCop: Fixed Style/DefWithParentheses offence Omit the parentheses in defs when the method doesn't accept any arguments. Change-Id: Id84ab9a759a95164a0db9dd35a0d7ebbfddf90df See: https://github.com/bbatsov/ruby-style-guide#method-parens Bug: T112651 --- M .rubocop_todo.yml M utils/hiera_lookup 2 files changed, 1 insertion(+), 7 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/operations/puppet refs/changes/08/259708/1 diff --git a/.rubocop_todo.yml b/.rubocop_todo.yml index 1ad9f5f..af0ea0c 100644 --- a/.rubocop_todo.yml +++ b/.rubocop_todo.yml @@ -96,12 +96,6 @@ - 'modules/ganeti/lib/facter/ganeti.rb' - 'modules/gridengine/lib/puppet/provider/gridengine_resource/parsed.rb' -# Offense count: 1 -# Cop supports --auto-correct. -Style/DefWithParentheses: - Exclude: - - 'utils/hiera_lookup' - # Offense count: 16 # Cop supports --auto-correct. # Configuration parameters: EnforcedStyle, SupportedStyles. diff --git a/utils/hiera_lookup b/utils/hiera_lookup index 1fa0528..f7103de 100755 --- a/utils/hiera_lookup +++ b/utils/hiera_lookup @@ -28,7 +28,7 @@ end # Get the scope from the command line arguments -def get_scope() +def get_scope # Transform the CL arguments in a dictionary in the form "::option" => argument scope = Hash[ARGV.map { |kv| "::#{kv.sub('--', '')}".split('=') }] abort(usage "Error: --fqdn=FQDN is required.") unless scope['::fqdn'] -- To view, visit https://gerrit.wikimedia.org/r/259708 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Id84ab9a759a95164a0db9dd35a0d7ebbfddf90df Gerrit-PatchSet: 1 Gerrit-Project: operations/puppet Gerrit-Branch: production Gerrit-Owner: Zfilipin <[email protected]> _______________________________________________ MediaWiki-commits mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
