Zfilipin has uploaded a new change for review. https://gerrit.wikimedia.org/r/259710
Change subject: RuboCop: fixed Style/EmptyLiteral offense ...................................................................... RuboCop: fixed Style/EmptyLiteral offense Use array literal [] instead of Array.new. Change-Id: If51b9bd88023b5fa1ae89dd8352c5d49df931598 See: https://github.com/bbatsov/ruby-style-guide#literal-array-hash Bug: T112651 --- M .rubocop_todo.yml M modules/admin/lib/puppet/parser/functions/unique_users.rb M modules/wmflib/lib/puppet/parser/functions/array_concat.rb 3 files changed, 2 insertions(+), 9 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/operations/puppet refs/changes/10/259710/1 diff --git a/.rubocop_todo.yml b/.rubocop_todo.yml index 1ad9f5f..981051d 100644 --- a/.rubocop_todo.yml +++ b/.rubocop_todo.yml @@ -108,13 +108,6 @@ Style/DotPosition: Enabled: false -# Offense count: 2 -# Cop supports --auto-correct. -Style/EmptyLiteral: - Exclude: - - 'modules/admin/lib/puppet/parser/functions/unique_users.rb' - - 'modules/wmflib/lib/puppet/parser/functions/array_concat.rb' - # Offense count: 1 # Configuration parameters: Exclude. Style/FileName: diff --git a/modules/admin/lib/puppet/parser/functions/unique_users.rb b/modules/admin/lib/puppet/parser/functions/unique_users.rb index ec62765..a354acb 100644 --- a/modules/admin/lib/puppet/parser/functions/unique_users.rb +++ b/modules/admin/lib/puppet/parser/functions/unique_users.rb @@ -2,7 +2,7 @@ newfunction(:unique_users, :type => :rvalue) do |args| myhash = args[0] applied_groups = args[1] - users = Array.new + users = [] for group in applied_groups if myhash['groups'].key?(group) users.push(myhash['groups'][group]['members']) diff --git a/modules/wmflib/lib/puppet/parser/functions/array_concat.rb b/modules/wmflib/lib/puppet/parser/functions/array_concat.rb index df9f60b..aee8af1 100644 --- a/modules/wmflib/lib/puppet/parser/functions/array_concat.rb +++ b/modules/wmflib/lib/puppet/parser/functions/array_concat.rb @@ -15,7 +15,7 @@ # module Puppet::Parser::Functions newfunction(:array_concat, :type => :rvalue) do |args| - retval = Array.new + retval = [] args.each do |arg| if arg.is_a? Array retval += arg -- To view, visit https://gerrit.wikimedia.org/r/259710 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: If51b9bd88023b5fa1ae89dd8352c5d49df931598 Gerrit-PatchSet: 1 Gerrit-Project: operations/puppet Gerrit-Branch: production Gerrit-Owner: Zfilipin <[email protected]> _______________________________________________ MediaWiki-commits mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
