Mobrovac has submitted this change and it was merged.
Change subject: Revert "Hotfix: Prevent \limits_{\binom} constructs from
parsing"
......................................................................
Revert "Hotfix: Prevent \limits_{\binom} constructs from parsing"
This reverts commit b641ab4e97e3ef269586a50be76547257bf966b0.
Change-Id: I44b3728bf042eaed01aaca7dc7e0687f2cf8915e
---
M routes/mathoid.js
1 file changed, 0 insertions(+), 34 deletions(-)
Approvals:
Mobrovac: Looks good to me, approved
jenkins-bot: Verified
diff --git a/routes/mathoid.js b/routes/mathoid.js
index f7b149a..f9faa92 100644
--- a/routes/mathoid.js
+++ b/routes/mathoid.js
@@ -59,40 +59,6 @@
var speakText = (outFormat !== "png") && features.speakText;
if (type === "TeX" || type === "inline-TeX") {
- /* TODO: TEMP TEMP TEMP
- * This is a nasty hack to prevent Mathoid from entering a
- * recursive loop, cf. https://phabricator.wikimedia.org/T121762
- */
- if (/\\limits_\{\s*\\binom\{/.test(q)) {
- throw new HTTPError({
- status: 500,
- success: false,
- title: 'Internal server error',
- type: 'internal_error',
- detail: {
- "success": false,
- "error": {
- "message": "\\limits_{\\binom is currently not
supported by Mathoid",
- "expected": [],
- "found": "\\biom",
- "location": {
- "start": {
- "offset": 0,
- "line": 1,
- "column": 0
- },
- "end": {
- "offset": 0,
- "line": 1,
- "column": 0
- }
- },
- }
- },
- error: "\\limits_{\\binom is currently not supported by
Mathoid"
- });
- }
- /* TODO: END TEMP */
var feedback = texvcInfo.feedback(q);
// XXX properly handle errors here!
if (feedback.success) {
--
To view, visit https://gerrit.wikimedia.org/r/259879
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I44b3728bf042eaed01aaca7dc7e0687f2cf8915e
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/services/mathoid
Gerrit-Branch: master
Gerrit-Owner: Mobrovac <[email protected]>
Gerrit-Reviewer: Mobrovac <[email protected]>
Gerrit-Reviewer: Physikerwelt <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
