jenkins-bot has submitted this change and it was merged.
Change subject: Check Hiera namespace permissions against root text of title
......................................................................
Check Hiera namespace permissions against root text of title
We don't allow '/' in project names.
Bug: T121602
Change-Id: I0647f3324349d6c2468030c38541154d0eb4f683
---
M OpenStackManagerHooks.php
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Legoktm: Looks good to me, approved
jenkins-bot: Verified
diff --git a/OpenStackManagerHooks.php b/OpenStackManagerHooks.php
index d332543..ecfc163 100644
--- a/OpenStackManagerHooks.php
+++ b/OpenStackManagerHooks.php
@@ -23,7 +23,7 @@
if ( !$userLDAP->exists() ) {
$result = array(
'openstackmanager-nonovacred-admincreate' );
}
- $project = $title->getText();
+ $project = $title->getRootText();
if ( !$userLDAP->inRole( 'projectadmin', $project ) &&
!$user->isAllowed( 'editallhiera' ) ) {
$result = array(
'openstackmanager-hiera-noadmin', $project );
return false;
--
To view, visit https://gerrit.wikimedia.org/r/259431
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I0647f3324349d6c2468030c38541154d0eb4f683
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/extensions/OpenStackManager
Gerrit-Branch: master
Gerrit-Owner: Alex Monk <[email protected]>
Gerrit-Reviewer: Andrew Bogott <[email protected]>
Gerrit-Reviewer: Legoktm <[email protected]>
Gerrit-Reviewer: Yuvipanda <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
