Yuvipanda has uploaded a new change for review. https://gerrit.wikimedia.org/r/259965
Change subject: Revert "redis: upstart should track PID after one fork" ...................................................................... Revert "redis: upstart should track PID after one fork" This was a terrible idea. The right fix was to cleanup the base config so that it doesn't keep the defaults from the legacy redis (which set deamonize to yes) This reverts commit ff3eca8ea6081085993407c10aa68f4ec9b60f4c. Change-Id: Iaefb2d191e79fda8f7b43df3067b80a127a26d20 --- M modules/redis/templates/initscripts/redis-instance.upstart.erb 1 file changed, 0 insertions(+), 1 deletion(-) git pull ssh://gerrit.wikimedia.org:29418/operations/puppet refs/changes/65/259965/1 diff --git a/modules/redis/templates/initscripts/redis-instance.upstart.erb b/modules/redis/templates/initscripts/redis-instance.upstart.erb index 69e1450..f906f81 100644 --- a/modules/redis/templates/initscripts/redis-instance.upstart.erb +++ b/modules/redis/templates/initscripts/redis-instance.upstart.erb @@ -5,7 +5,6 @@ setuid redis setgid redis -expect fork exec /usr/bin/redis-server /etc/redis/<%= @instance_name %>.conf respawn -- To view, visit https://gerrit.wikimedia.org/r/259965 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Iaefb2d191e79fda8f7b43df3067b80a127a26d20 Gerrit-PatchSet: 1 Gerrit-Project: operations/puppet Gerrit-Branch: production Gerrit-Owner: Yuvipanda <[email protected]> _______________________________________________ MediaWiki-commits mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
