Ottomata has uploaded a new change for review.
https://gerrit.wikimedia.org/r/260016
Change subject: Fix for kafka broker port ferm rule
......................................................................
Fix for kafka broker port ferm rule
Change-Id: I93ba6c9624c45903cdd339411adfe368c86c5793
---
M modules/role/manifests/kafka/analytics/broker.pp
M modules/role/manifests/kafka/main/broker.pp
2 files changed, 2 insertions(+), 8 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/operations/puppet
refs/changes/16/260016/1
diff --git a/modules/role/manifests/kafka/analytics/broker.pp
b/modules/role/manifests/kafka/analytics/broker.pp
index 63edeb0..a491a90 100644
--- a/modules/role/manifests/kafka/analytics/broker.pp
+++ b/modules/role/manifests/kafka/analytics/broker.pp
@@ -109,10 +109,7 @@
# firewall Kafka Broker
ferm::service { 'kafka-broker':
proto => 'tcp',
- # TODO: A custom port can be configured in
- # $brokers_config. Extract the proper
- # port to open from that config hash.
- port => 9999,
+ port => $::kafka::server::broker_port,
srange => '$ALL_NETWORKS',
}
diff --git a/modules/role/manifests/kafka/main/broker.pp
b/modules/role/manifests/kafka/main/broker.pp
index 0fd373d..c833164 100644
--- a/modules/role/manifests/kafka/main/broker.pp
+++ b/modules/role/manifests/kafka/main/broker.pp
@@ -69,10 +69,7 @@
# firewall Kafka Broker
ferm::service { 'kafka-broker':
proto => 'tcp',
- # TODO: A custom port can be configured in
- # $brokers_config. Extract the proper
- # port to open from that config hash.
- port => 9999,
+ port => $::kafka::server::broker_port,
srange => '$ALL_NETWORKS',
}
--
To view, visit https://gerrit.wikimedia.org/r/260016
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I93ba6c9624c45903cdd339411adfe368c86c5793
Gerrit-PatchSet: 1
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Ottomata <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
