Reedy has uploaded a new change for review.
https://gerrit.wikimedia.org/r/260235
Change subject: ApiQueryBase titleToKey(), keyToTitle() and keyPartToTitle()
removed
......................................................................
ApiQueryBase titleToKey(), keyToTitle() and keyPartToTitle() removed
All deprecated since 1.24.
Change-Id: I8cf91a12d564dc6b2c48ead5f3f382bebb0217bc
---
M RELEASE-NOTES-1.27
M includes/api/ApiQueryBase.php
2 files changed, 2 insertions(+), 53 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core
refs/changes/35/260235/1
diff --git a/RELEASE-NOTES-1.27 b/RELEASE-NOTES-1.27
index cc78a8a..0264889 100644
--- a/RELEASE-NOTES-1.27
+++ b/RELEASE-NOTES-1.27
@@ -187,6 +187,8 @@
* MWHookException was removed.
* OutputPage::appendSubtitle() was removed (deprecated since 1.19).
* OutputPage::loginToUse() was removed (deprecated since 1.19).
+* ApiQueryBase::titleToKey(), ApiQueryBase::keyToTitle() and
+ ApiQueryBase::keyPartToTitle() all removed (deprecated since 1.24).
== Compatibility ==
diff --git a/includes/api/ApiQueryBase.php b/includes/api/ApiQueryBase.php
index 01968c2..7ff1868 100644
--- a/includes/api/ApiQueryBase.php
+++ b/includes/api/ApiQueryBase.php
@@ -612,59 +612,6 @@
}
/**
- * Convert a title to a DB key
- * @deprecated since 1.24, past uses of this were always incorrect and
should
- * have used self::titlePartToKey() instead
- * @param string $title Page title with spaces
- * @return string Page title with underscores
- */
- public function titleToKey( $title ) {
- wfDeprecated( __METHOD__, '1.24' );
- // Don't throw an error if we got an empty string
- if ( trim( $title ) == '' ) {
- return '';
- }
- $t = Title::newFromText( $title );
- if ( !$t ) {
- $this->dieUsageMsg( array( 'invalidtitle', $title ) );
- }
-
- return $t->getPrefixedDBkey();
- }
-
- /**
- * The inverse of titleToKey()
- * @deprecated since 1.24, unused and probably never needed
- * @param string $key Page title with underscores
- * @return string Page title with spaces
- */
- public function keyToTitle( $key ) {
- wfDeprecated( __METHOD__, '1.24' );
- // Don't throw an error if we got an empty string
- if ( trim( $key ) == '' ) {
- return '';
- }
- $t = Title::newFromDBkey( $key );
- // This really shouldn't happen but we gotta check anyway
- if ( !$t ) {
- $this->dieUsageMsg( array( 'invalidtitle', $key ) );
- }
-
- return $t->getPrefixedText();
- }
-
- /**
- * Inverse of titlePartToKey()
- * @deprecated since 1.24, unused and probably never needed
- * @param string $keyPart DBkey, with prefix
- * @return string Key part with underscores
- */
- public function keyPartToTitle( $keyPart ) {
- wfDeprecated( __METHOD__, '1.24' );
- return substr( $this->keyToTitle( $keyPart . 'x' ), 0, -1 );
- }
-
- /**
* Gets the personalised direction parameter description
*
* @deprecated since 1.25 along with ApiBase::getParamDescription
--
To view, visit https://gerrit.wikimedia.org/r/260235
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I8cf91a12d564dc6b2c48ead5f3f382bebb0217bc
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Reedy <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
