Umherirrender has submitted this change and it was merged.
Change subject: Avoid calling lazyImportLocalNames() in a few spaces
......................................................................
Avoid calling lazyImportLocalNames() in a few spaces
Simplify addLocalName()/removeLocalName() to skip calling this.
They both do the same unconditional DB update anyway.
Change-Id: I46bfef71e1cd544377017273f7be1ae989d72332
---
M includes/CentralAuthUser.php
1 file changed, 0 insertions(+), 2 deletions(-)
Approvals:
Krinkle: Looks good to me, approved
Umherirrender: Verified; Looks good to me, approved
diff --git a/includes/CentralAuthUser.php b/includes/CentralAuthUser.php
index a7402a6..2c6392c 100644
--- a/includes/CentralAuthUser.php
+++ b/includes/CentralAuthUser.php
@@ -1930,7 +1930,6 @@
*/
function addLocalName( $wikiID ) {
$dbw = self::getCentralDB();
- $this->lazyImportLocalNames();
$dbw->insert( 'localnames',
array(
'ln_wiki' => $wikiID,
@@ -1945,7 +1944,6 @@
*/
function removeLocalName( $wikiID ) {
$dbw = self::getCentralDB();
- $this->lazyImportLocalNames();
$dbw->delete( 'localnames',
array(
'ln_wiki' => $wikiID,
--
To view, visit https://gerrit.wikimedia.org/r/258402
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I46bfef71e1cd544377017273f7be1ae989d72332
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/extensions/CentralAuth
Gerrit-Branch: master
Gerrit-Owner: Aaron Schulz <[email protected]>
Gerrit-Reviewer: Aaron Schulz <[email protected]>
Gerrit-Reviewer: Hashar <[email protected]>
Gerrit-Reviewer: Krinkle <[email protected]>
Gerrit-Reviewer: Legoktm <[email protected]>
Gerrit-Reviewer: Umherirrender <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
