Reedy has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/260307

Change subject: Fix Fatal on various special pages introduced in 1.24.5
......................................................................

Fix Fatal on various special pages introduced in 1.24.5

Bug: T121892
Change-Id: Ie3d23af7a372fa6a5a23cd861a4d34e42fb08195
---
M RELEASE-NOTES-1.24
M includes/MediaWiki.php
2 files changed, 10 insertions(+), 3 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core 
refs/changes/07/260307/1

diff --git a/RELEASE-NOTES-1.24 b/RELEASE-NOTES-1.24
index 3dc9761..9000cd5 100644
--- a/RELEASE-NOTES-1.24
+++ b/RELEASE-NOTES-1.24
@@ -1,9 +1,16 @@
 Security reminder: If you have PHP's register_globals option set, you must
 turn it off. MediaWiki will no longer work with it enabled.
 
+== MediaWiki 1.24.6 ==
+
+THIS IS NOT A RELEASE YET!
+
+== Changes since 1.24.5 ==
+* (T121892) Fix fatal error on some Special pages, introduced in 1.24.5.
+
 == MediaWiki 1.24.5 ==
 
-This is a security and maintenance release of the MediaWiki 1.23 branch.
+This is a security and maintenance release of the MediaWiki 1.24 branch.
 
 == Changes since 1.24.4 ==
 * (T117899) SECURITY: $wgArticlePath can no longer be set to relative paths
diff --git a/includes/MediaWiki.php b/includes/MediaWiki.php
index b828ad3..b703a4f 100644
--- a/includes/MediaWiki.php
+++ b/includes/MediaWiki.php
@@ -158,7 +158,7 @@
         * @return void
         */
        private function performRequest() {
-               global $wgTitle;
+               global $wgTitle, $wgHideIdentifiableRedirects;
 
                wfProfileIn( __METHOD__ );
 
@@ -237,7 +237,7 @@
                        if ( $title->isSpecialPage() ) {
                                $specialPage = SpecialPageFactory::getPage( 
$title->getDBKey() );
                                if ( $specialPage instanceof RedirectSpecialPage
-                                       && $this->config->get( 
'HideIdentifiableRedirects' )
+                                       && $wgHideIdentifiableRedirects
                                        && 
$specialPage->personallyIdentifiableTarget()
                                ) {
                                        list( , $subpage ) = 
SpecialPageFactory::resolveAlias( $title->getDBKey() );

-- 
To view, visit https://gerrit.wikimedia.org/r/260307
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ie3d23af7a372fa6a5a23cd861a4d34e42fb08195
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: REL1_24
Gerrit-Owner: Reedy <[email protected]>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to