Ananay has uploaded a new change for review.
https://gerrit.wikimedia.org/r/260327
Change subject: Remove JS adding/removing 'hover' CSS class, use :hover
pseudoclass instead in UploadWizard (Wikimedia)
......................................................................
Remove JS adding/removing 'hover' CSS class, use :hover pseudoclass instead in
UploadWizard (Wikimedia)
Change-Id: I47624f944b4a67db82c957a242f6f98e7904957a
---
M resources/jquery/jquery.showThumbCtrl.js
M resources/uploadWizard.css
2 files changed, 3 insertions(+), 10 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/UploadWizard
refs/changes/27/260327/1
diff --git a/resources/jquery/jquery.showThumbCtrl.js
b/resources/jquery/jquery.showThumbCtrl.js
index de23b2f..bb4a9ca 100644
--- a/resources/jquery/jquery.showThumbCtrl.js
+++ b/resources/jquery/jquery.showThumbCtrl.js
@@ -8,16 +8,9 @@
.attr( 'title', mw.message( tooltipMsgKey ).escaped() )
.click( function () {
$( this )
- .removeClass( 'hover' )
.addClass( 'disabled' )
.unbind( 'mouseenter mouseover
mouseleave mouseout mouseup mousedown' );
callback();
- } )
- .hover( function () {
- $( this ).addClass( 'hover' );
- },
- function () {
- $( this ).removeClass( 'hover' );
} )
.append( $( '<div class="ui-icon ui-icon-image" /><div
class="mwe-upwiz-show-thumb-ctrl-msg">' + msg + '</div>' ) );
};
diff --git a/resources/uploadWizard.css b/resources/uploadWizard.css
index 13f7353..12201ff 100644
--- a/resources/uploadWizard.css
+++ b/resources/uploadWizard.css
@@ -65,7 +65,7 @@
}
/* NOT a pseudoclass */
-#mwe-upwiz-add-file.hover {
+#mwe-upwiz-add-file:hover {
text-decoration: underline;
}
@@ -257,7 +257,7 @@
overflow: hidden;
}
-.mwe-upwiz-file.hover .mwe-upwiz-visible-file {
+.mwe-upwiz-file:hover .mwe-upwiz-visible-file {
background: #e0f0ff !important;
}
@@ -298,7 +298,7 @@
background: url('images/24px-spinner-0645ad-f5f5f5.gif') no-repeat
center center;
}
-.mwe-upwiz-file.hover .mwe-upwiz-status-progress {
+.mwe-upwiz-file:hover .mwe-upwiz-status-progress {
/* @embed */
background: url('images/24px-spinner-0645ad-e0f0ff.gif') no-repeat
center center;
}
--
To view, visit https://gerrit.wikimedia.org/r/260327
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I47624f944b4a67db82c957a242f6f98e7904957a
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/UploadWizard
Gerrit-Branch: master
Gerrit-Owner: Ananay <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
