jenkins-bot has submitted this change and it was merged.
Change subject: page.py: define args as keyword args in page._save()
......................................................................
page.py: define args as keyword args in page._save()
Explicitly define args as keyword args.
Also reorder _save args to be consistent with the order of save args.
Change-Id: I6c38435a170838370172721bd3c7acbd93b3597b
---
M pywikibot/page.py
1 file changed, 6 insertions(+), 6 deletions(-)
Approvals:
John Vandenberg: Looks good to me, approved
jenkins-bot: Verified
diff --git a/pywikibot/page.py b/pywikibot/page.py
index b4ffaf4..34f30b6 100644
--- a/pywikibot/page.py
+++ b/pywikibot/page.py
@@ -1124,18 +1124,18 @@
raise pywikibot.OtherPageSaveError(
self, "Editing restricted by {{bots}} template")
if async:
- pywikibot.async_request(self._save, summary=summary, minor=minor,
- watch=watch, botflag=botflag,
+ pywikibot.async_request(self._save, summary=summary, watch=watch,
+ minor=minor, botflag=botflag,
async=async, callback=callback,
cc=apply_cosmetic_changes,
quiet=quiet, **kwargs)
else:
- self._save(summary=summary, minor=minor, watch=watch,
+ self._save(summary=summary, watch=watch, minor=minor,
botflag=botflag, async=async, callback=callback,
- cc=apply_cosmetic_changes, **kwargs)
+ cc=apply_cosmetic_changes, quiet=quiet, **kwargs)
- def _save(self, summary, minor, watch, botflag, async, callback,
- cc, quiet=False, **kwargs):
+ def _save(self, summary=None, watch=None, minor=True, botflag=None,
+ async=False, callback=None, cc=None, quiet=False, **kwargs):
"""Helper function for save()."""
err = None
link = self.title(asLink=True)
--
To view, visit https://gerrit.wikimedia.org/r/248713
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I6c38435a170838370172721bd3c7acbd93b3597b
Gerrit-PatchSet: 5
Gerrit-Project: pywikibot/core
Gerrit-Branch: master
Gerrit-Owner: Mpaa <[email protected]>
Gerrit-Reviewer: John Vandenberg <[email protected]>
Gerrit-Reviewer: Ladsgroup <[email protected]>
Gerrit-Reviewer: Mpaa <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
