Santhosh has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/260534

Change subject: Don't leave non-CX URL params while going from dashboard to 
translationview
......................................................................

Don't leave non-CX URL params while going from dashboard to translationview

Leaving debug=true was annoying while debugging.

Change-Id: I7dea28fb5057a04ff89e7a1690dca0d23f054928
---
M modules/base/ext.cx.sitemapper.js
1 file changed, 3 insertions(+), 1 deletion(-)


  git pull 
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/ContentTranslation 
refs/changes/34/260534/1

diff --git a/modules/base/ext.cx.sitemapper.js 
b/modules/base/ext.cx.sitemapper.js
index 361cb87..d237436 100644
--- a/modules/base/ext.cx.sitemapper.js
+++ b/modules/base/ext.cx.sitemapper.js
@@ -152,7 +152,9 @@
 
                if ( mw.config.get( 'wgContentTranslationTranslateInTarget' ) ) 
{
                        uri = new mw.Uri( this.getPageUrl( targetLanguage, 
cxPage ) );
-                       $.extend( uri.query, queryParams );
+                       // Use  mw.Uri().query as well to retain any non-CX 
params in URL
+                       // A good example is debug=true param.
+                       $.extend( uri.query, mw.Uri().query, queryParams );
 
                        return uri.toString();
                }

-- 
To view, visit https://gerrit.wikimedia.org/r/260534
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I7dea28fb5057a04ff89e7a1690dca0d23f054928
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/ContentTranslation
Gerrit-Branch: master
Gerrit-Owner: Santhosh <santhosh.thottin...@gmail.com>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to