[MediaWiki-commits] [Gerrit] Remove not needed globals and split nested assignments - change (data-values/value-view)

[WMDE]

Thiemo Mättig (WMDE) has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/260567

Change subject: Remove not needed globals and split nested assignments
......................................................................

Remove not needed globals and split nested assignments

This fixes a few issues as reported by PHPStorm's code analysis.

Change-Id: I0589270550a235b97430c600ee91cbe002f1159d
---
M lib/jquery.ui/jquery.ui.inputextender.js
M lib/jquery.util/jquery.util.adaptlettercase.js
M lib/jquery/jquery.focusAt.js
3 files changed, 6 insertions(+), 5 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/data-values/value-view 
refs/changes/67/260567/1

diff --git a/lib/jquery.ui/jquery.ui.inputextender.js 
b/lib/jquery.ui/jquery.ui.inputextender.js
index c513439..6629b7e 100644
--- a/lib/jquery.ui/jquery.ui.inputextender.js
+++ b/lib/jquery.ui/jquery.ui.inputextender.js
@@ -344,7 +344,8 @@
                }
 
                if ( !$extension ) {
-                       this._$extension = $extension = this._buildExtension();
+                       $extension = this._buildExtension();
+                       this._$extension = $extension;
                        $extension.appendTo( $( 'body' ) );
 
                        if ( $.isFunction( this.options.initCallback ) ) {
diff --git a/lib/jquery.util/jquery.util.adaptlettercase.js 
b/lib/jquery.util/jquery.util.adaptlettercase.js
index 30aad2b..778b762 100644
--- a/lib/jquery.util/jquery.util.adaptlettercase.js
+++ b/lib/jquery.util/jquery.util.adaptlettercase.js
@@ -1,6 +1,6 @@
 jQuery.util = jQuery.util || {};
 
-jQuery.util.adaptlettercase = ( function( $ ) {
+jQuery.util.adaptlettercase = ( function() {
        'use strict';
 
        /**
@@ -38,4 +38,4 @@
                }
        };
 
-} )( jQuery );
+} )();
diff --git a/lib/jquery/jquery.focusAt.js b/lib/jquery/jquery.focusAt.js
index 8a3fea8..7718eb6 100644
--- a/lib/jquery/jquery.focusAt.js
+++ b/lib/jquery/jquery.focusAt.js
@@ -1,4 +1,4 @@
-jQuery.fn.focusAt = ( function( $ ) {
+jQuery.fn.focusAt = ( function() {
        'use strict';
 
        /**
@@ -108,4 +108,4 @@
 
        return focusAt;
 
-}( jQuery ) );
+}() );

-- 
To view, visit https://gerrit.wikimedia.org/r/260567
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I0589270550a235b97430c600ee91cbe002f1159d
Gerrit-PatchSet: 1
Gerrit-Project: data-values/value-view
Gerrit-Branch: master
Gerrit-Owner: Thiemo Mättig (WMDE) <thiemo.maet...@wikimedia.de>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits