Ottomata has submitted this change and it was merged.
Change subject: Fix uncaught exception when creating event error for event
without scid
......................................................................
Fix uncaught exception when creating event error for event without scid
Change-Id: I8888d27b9615bf46aa1c95633cccc4aa573ca0ac
---
M eventlogging/event.py
1 file changed, 3 insertions(+), 1 deletion(-)
Approvals:
Ottomata: Looks good to me, approved
jenkins-bot: Verified
diff --git a/eventlogging/event.py b/eventlogging/event.py
index 36a7dec..e2ffd49 100644
--- a/eventlogging/event.py
+++ b/eventlogging/event.py
@@ -240,7 +240,9 @@
# If we've got a parsed event, then we can just get the schema
# and revision out of the object.
if parsed_event:
- errored_schema, errored_revision = parsed_event.scid()
+ scid = parsed_event.scid()
+ if scid:
+ errored_schema, errored_revision = scid
# otherwise attempt to get them out of the raw_event with a regex
else:
--
To view, visit https://gerrit.wikimedia.org/r/260584
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I8888d27b9615bf46aa1c95633cccc4aa573ca0ac
Gerrit-PatchSet: 1
Gerrit-Project: eventlogging
Gerrit-Branch: master
Gerrit-Owner: Ottomata <[email protected]>
Gerrit-Reviewer: Ottomata <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
