Andrew Bogott has submitted this change and it was merged. Change subject: openstack: rename openstack-manager class ......................................................................
openstack: rename openstack-manager class Puppet classes and defines should not contain dash characters per lint and style guide and we only have a handful of those left. Change-Id: I3e87ec979fd8f1f97c8dc105d428175a866493c8 --- R modules/openstack/manifests/openstack_manager.pp M modules/role/manifests/labs/openstack/nova.pp 2 files changed, 2 insertions(+), 2 deletions(-) Approvals: Andrew Bogott: Looks good to me, approved jenkins-bot: Verified diff --git a/modules/openstack/manifests/openstack-manager.pp b/modules/openstack/manifests/openstack_manager.pp similarity index 98% rename from modules/openstack/manifests/openstack-manager.pp rename to modules/openstack/manifests/openstack_manager.pp index 8e35e29..8ef1dbb 100644 --- a/modules/openstack/manifests/openstack-manager.pp +++ b/modules/openstack/manifests/openstack_manager.pp @@ -1,5 +1,5 @@ # https://www.mediawiki.org/wiki/Extension:OpenStackManager -class openstack::openstack-manager( +class openstack::openstack_manager( $novaconfig, $certificate, $openstack_version = $::openstack::version, diff --git a/modules/role/manifests/labs/openstack/nova.pp b/modules/role/manifests/labs/openstack/nova.pp index b15a20a..69051b0 100644 --- a/modules/role/manifests/labs/openstack/nova.pp +++ b/modules/role/manifests/labs/openstack/nova.pp @@ -78,7 +78,7 @@ rule => 'proto tcp dport ssh saddr $DEPLOYMENT_HOSTS ACCEPT;', } - class { '::openstack::openstack-manager': + class { '::openstack::openstack_manager': novaconfig => $novaconfig, certificate => $certificate, } -- To view, visit https://gerrit.wikimedia.org/r/260192 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3e87ec979fd8f1f97c8dc105d428175a866493c8 Gerrit-PatchSet: 2 Gerrit-Project: operations/puppet Gerrit-Branch: production Gerrit-Owner: Dzahn <[email protected]> Gerrit-Reviewer: Andrew Bogott <[email protected]> Gerrit-Reviewer: Yuvipanda <[email protected]> Gerrit-Reviewer: jenkins-bot <> _______________________________________________ MediaWiki-commits mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
