Mooeypoo has uploaded a new change for review.
https://gerrit.wikimedia.org/r/260772
Change subject: Log the expand action of a notification group item
......................................................................
Log the expand action of a notification group item
Bug: T121945
Change-Id: I171d3e99a5529172177c9ddb9f17429609180321
---
M modules/logger/mw.echo.Logger.js
M modules/ooui/mw.echo.ui.NotificationGroupItemWidget.js
2 files changed, 9 insertions(+), 0 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Echo
refs/changes/72/260772/1
diff --git a/modules/logger/mw.echo.Logger.js b/modules/logger/mw.echo.Logger.js
index 23ad812..3e1e936 100644
--- a/modules/logger/mw.echo.Logger.js
+++ b/modules/logger/mw.echo.Logger.js
@@ -74,6 +74,7 @@
*/
mw.echo.Logger.static.actions = {
notificationClick: 'notification-link-click',
+ notificationBundleExpand: 'notification-bundle-expand',
notificationImpression: 'notification-impression'
};
diff --git a/modules/ooui/mw.echo.ui.NotificationGroupItemWidget.js
b/modules/ooui/mw.echo.ui.NotificationGroupItemWidget.js
index 66b68ce..3b1a5de 100644
--- a/modules/ooui/mw.echo.ui.NotificationGroupItemWidget.js
+++ b/modules/ooui/mw.echo.ui.NotificationGroupItemWidget.js
@@ -128,6 +128,14 @@
.then( function ( /* Groups */ ) {
widget.popPending();
} );
+
+ // Log the expand action
+ mw.echo.logger.logInteraction(
+
mw.echo.Logger.static.actions.notificationBundleExpand,
+ mw.echo.Logger.static.context.popup,
+ widget.getModel().getId(),
+ widget.getModel().getCategory()
+ );
}
};
--
To view, visit https://gerrit.wikimedia.org/r/260772
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I171d3e99a5529172177c9ddb9f17429609180321
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Echo
Gerrit-Branch: master
Gerrit-Owner: Mooeypoo <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
