Ori.livneh has uploaded a new change for review. Change subject: Bits VCL for EventLogging: require query to match ......................................................................
Bits VCL for EventLogging: require query to match Because the current regexp doesn't care what comes after /event.gif in the path, when someone hits http://bits.wikimedia.org/event.gif (with no query string at all), varnishncsa correctly outputs an empty query string field, and the resultant log line contains four rather than five space-separated values. This requires coding for that special case in several places, which sucks. This change makes the EventLogging regexp only match when /event.gif is followed by a nonempty query string. Change-Id: I38056e51dc7558ebba3b10956ab53e0177f1da40 --- M templates/varnish/bits.inc.vcl.erb 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.wikimedia.org:29418/operations/puppet refs/changes/42/41942/1 -- To view, visit https://gerrit.wikimedia.org/r/41942 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I38056e51dc7558ebba3b10956ab53e0177f1da40 Gerrit-PatchSet: 1 Gerrit-Project: operations/puppet Gerrit-Branch: production Gerrit-Owner: Ori.livneh <[email protected]> _______________________________________________ MediaWiki-commits mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
