jenkins-bot has submitted this change and it was merged.
Change subject: mediawiki.util: Remove outdated comment from unit test
......................................................................
mediawiki.util: Remove outdated comment from unit test
'wgArticlePath' is actually in the startup module, but that is irrelevant
since tests should (and do) mock these configs regardless of whether they
have defaults so that they work regardless of the wiki configuration.
Change-Id: I8b9321ed9f578b614f5d89fe8ab0ab6ad9f508f2
---
M tests/qunit/suites/resources/mediawiki/mediawiki.util.test.js
1 file changed, 8 insertions(+), 5 deletions(-)
Approvals:
Bartosz Dziewoński: Looks good to me, approved
jenkins-bot: Verified
diff --git a/tests/qunit/suites/resources/mediawiki/mediawiki.util.test.js
b/tests/qunit/suites/resources/mediawiki/mediawiki.util.test.js
index 0b98106..5d72179 100644
--- a/tests/qunit/suites/resources/mediawiki/mediawiki.util.test.js
+++ b/tests/qunit/suites/resources/mediawiki/mediawiki.util.test.js
@@ -137,9 +137,10 @@
} );
QUnit.test( 'getUrl', 12, function ( assert ) {
- // Not part of startUp module
- mw.config.set( 'wgArticlePath', '/wiki/$1' );
- mw.config.set( 'wgPageName', 'Foobar' );
+ mw.config.set( {
+ wgArticlePath: '/wiki/$1',
+ wgPageName: 'Foobar'
+ } );
var href = mw.util.getUrl( 'Sandbox' );
assert.equal( href, '/wiki/Sandbox', 'simple title' );
@@ -181,8 +182,10 @@
QUnit.test( 'wikiScript', 4, function ( assert ) {
mw.config.set( {
- wgScript: '/w/i.php', // customized wgScript for bug
39103
- wgLoadScript: '/w/l.php', // customized wgLoadScript
for bug 39103
+ // customized wgScript for T41103
+ wgScript: '/w/i.php',
+ // customized wgLoadScript for T41103
+ wgLoadScript: '/w/l.php',
wgScriptPath: '/w'
} );
--
To view, visit https://gerrit.wikimedia.org/r/260684
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I8b9321ed9f578b614f5d89fe8ab0ab6ad9f508f2
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Krinkle <[email protected]>
Gerrit-Reviewer: Bartosz Dziewoński <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
