OliverKeyes has submitted this change and it was merged.
Change subject: Patch to correct zrr calculation
......................................................................
Patch to correct zrr calculation
Change-Id: I302bd9e32cbc7a5fdcd2361c4e2b6ec490e64c10
---
M search/zrr.R
1 file changed, 7 insertions(+), 8 deletions(-)
Approvals:
OliverKeyes: Verified; Looks good to me, approved
diff --git a/search/zrr.R b/search/zrr.R
index f231918..ec54b54 100644
--- a/search/zrr.R
+++ b/search/zrr.R
@@ -60,24 +60,23 @@
data$has_suggestion <- (data$has_suggestion == "true")
# Bind in the date
- data <- as.data.table(cbind(data.frame(date = rep(date,nrow(data))),
- data))
+ data <- as.data.table(cbind(data.frame(date = rep(date, nrow(data))), data))
# Data by type
- by_type_with_automata <- data[,list(rate =
round(sum(total)/sum(zero_results), 2)), by = c("date", "query_type")]
+ by_type_with_automata <- data[,list(rate =
round(sum(zero_results)/sum(total), 2)), by = c("date", "query_type")]
by_type_no_automata <- data[data$is_automata == FALSE,
- list(rate = round(sum(total)/sum(zero_results),
2)), by = c("date", "query_type")]
+ list(rate = round(sum(zero_results)/sum(total),
2)), by = c("date", "query_type")]
# Overall data
- overall_data_with_automata <- data[,list(rate =
round(sum(total)/sum(zero_results), 2)), by = c("date")]
+ overall_data_with_automata <- data[,list(rate =
round(sum(zero_results)/sum(total), 2)), by = c("date")]
overall_data_no_automata <- data[data$is_automata == FALSE,
- list(rate =
round(sum(total)/sum(zero_results), 2)), by = c("date")]
+ list(rate =
round(sum(zero_results)/sum(total), 2)), by = c("date")]
# Suggestion data
suggestion_data <- data[data$has_suggestion == TRUE,]
- suggestion_data_with_automata <- suggestion_data[,list(rate =
round(sum(total)/sum(zero_results), 2)), by = c("date")]
+ suggestion_data_with_automata <- suggestion_data[,list(rate =
round(sum(zero_results)/sum(total), 2)), by = c("date")]
suggestion_data_no_automata <- suggestion_data[suggestion_data$is_automata
== FALSE,
- list(rate =
round(sum(total)/sum(zero_results), 2)), by = c("date")]
+ list(rate =
round(sum(zero_results)/sum(total), 2)), by = c("date")]
conditional_write(by_type_with_automata, file.path(base_path,
"cirrus_query_breakdowns_with_automata.tsv"))
--
To view, visit https://gerrit.wikimedia.org/r/260794
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I302bd9e32cbc7a5fdcd2361c4e2b6ec490e64c10
Gerrit-PatchSet: 1
Gerrit-Project: wikimedia/discovery/golden
Gerrit-Branch: master
Gerrit-Owner: Bearloga <[email protected]>
Gerrit-Reviewer: OliverKeyes <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
