jenkins-bot has submitted this change and it was merged.
Change subject: SpecialContributions: Simplify check for
'Special:Contributions/newbies'
......................................................................
SpecialContributions: Simplify check for 'Special:Contributions/newbies'
Added in 54615b5ea1a05caf40461b46193b4779e912f528 (per T36659)
as a possibly temporary workaround, it has stuck around for six
release versions now. It's not going to suddenly disappear
and we shouldn't optimize this code for ease of removal :)
Bug: T36659
Change-Id: I946ae7cf164f5c71b2ea4023161df7452bd1745a
---
M includes/specials/SpecialContributions.php
1 file changed, 1 insertion(+), 5 deletions(-)
Approvals:
Aaron Schulz: Looks good to me, approved
jenkins-bot: Verified
diff --git a/includes/specials/SpecialContributions.php
b/includes/specials/SpecialContributions.php
index fc9f750..bf3ab90 100644
--- a/includes/specials/SpecialContributions.php
+++ b/includes/specials/SpecialContributions.php
@@ -49,11 +49,7 @@
$target = $request->getVal( 'target' );
}
- // check for radiobox
- if ( $request->getVal( 'contribs' ) == 'newbie' ) {
- $target = 'newbies';
- $this->opts['contribs'] = 'newbie';
- } elseif ( $par === 'newbies' ) { // b/c for WMF
+ if ( $request->getVal( 'contribs' ) == 'newbie' || $par ===
'newbies' ) {
$target = 'newbies';
$this->opts['contribs'] = 'newbie';
} else {
--
To view, visit https://gerrit.wikimedia.org/r/260859
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I946ae7cf164f5c71b2ea4023161df7452bd1745a
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Bartosz Dziewoński <[email protected]>
Gerrit-Reviewer: Aaron Schulz <[email protected]>
Gerrit-Reviewer: Florianschmidtwelzow <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
