Nemo bis has uploaded a new change for review.
https://gerrit.wikimedia.org/r/260962
Change subject: Fix "Undefined property: DiffEngine::$seq" under HHVM in
DairikiDiff.php
......................................................................
Fix "Undefined property: DiffEngine::$seq" under HHVM in DairikiDiff.php
Bug: T116266
Change-Id: I94ed1ce946b4c3e757405167d6c4530a5863a220
(cherry picked from commit bd43acbca60b49ecb07aed37eecc8f59341f14e2)
---
M includes/diff/DairikiDiff.php
1 file changed, 3 insertions(+), 3 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core
refs/changes/62/260962/1
diff --git a/includes/diff/DairikiDiff.php b/includes/diff/DairikiDiff.php
index d327433..7bdc654 100644
--- a/includes/diff/DairikiDiff.php
+++ b/includes/diff/DairikiDiff.php
@@ -296,9 +296,9 @@
$this->xchanged = $this->ychanged = array();
$this->xv = $this->yv = array();
$this->xind = $this->yind = array();
- unset( $this->seq );
- unset( $this->in_seq );
- unset( $this->lcs );
+ $this->seq = array();
+ $this->in_seq = array();
+ $this->lcs = 0;
// Skip leading common lines.
for ( $skip = 0; $skip < $n_from && $skip < $n_to;
$skip++ ) {
--
To view, visit https://gerrit.wikimedia.org/r/260962
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I94ed1ce946b4c3e757405167d6c4530a5863a220
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: REL1_26
Gerrit-Owner: Nemo bis <federicol...@tiscali.it>
Gerrit-Reviewer: Edward Chernenko <edwards...@gmail.com>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
