WikidataBuilder has uploaded a new change for review.
https://gerrit.wikimedia.org/r/261181
Change subject: New Wikidata Build - 2015-12-28T10:00:02+0000
......................................................................
New Wikidata Build - 2015-12-28T10:00:02+0000
Change-Id: Ib7c8251afb4ef72a3b12d0d2a08f006ae4175867
---
M composer.lock
M extensions/PropertySuggester/PropertySuggester.php
M extensions/PropertySuggester/README.md
M extensions/PropertySuggester/i18n/en.json
M extensions/PropertySuggester/i18n/qqq.json
M extensions/PropertySuggester/src/PropertySuggester/GetSuggestions.php
M
extensions/PropertySuggester/tests/phpunit/PropertySuggester/GetSuggestionsTest.php
M vendor/composer/installed.json
8 files changed, 67 insertions(+), 68 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Wikidata
refs/changes/81/261181/1
diff --git a/composer.lock b/composer.lock
index 33ecf7a..7a25536 100644
--- a/composer.lock
+++ b/composer.lock
@@ -773,16 +773,16 @@
},
{
"name": "propertysuggester/property-suggester",
- "version": "2.4.4",
+ "version": "2.4.5",
"source": {
"type": "git",
"url": "https://github.com/Wikidata-lib/PropertySuggester.git";,
- "reference": "398b914576947ceb8dedd803a9e15090f982fa25"
+ "reference": "96d2eeb9a3f926f9169e9bc150cc66440ea85ace"
},
"dist": {
"type": "zip",
- "url":
"https://api.github.com/repos/Wikidata-lib/PropertySuggester/zipball/398b914576947ceb8dedd803a9e15090f982fa25";,
- "reference": "398b914576947ceb8dedd803a9e15090f982fa25",
+ "url":
"https://api.github.com/repos/Wikidata-lib/PropertySuggester/zipball/96d2eeb9a3f926f9169e9bc150cc66440ea85ace";,
+ "reference": "96d2eeb9a3f926f9169e9bc150cc66440ea85ace",
"shasum": ""
},
"require": {
@@ -816,7 +816,7 @@
"wikibase",
"wikidata"
],
- "time": "2015-10-14 21:06:09"
+ "time": "2015-12-27 10:13:49"
},
{
"name": "serialization/serialization",
diff --git a/extensions/PropertySuggester/PropertySuggester.php
b/extensions/PropertySuggester/PropertySuggester.php
index d19a0ab..ab3d177 100644
--- a/extensions/PropertySuggester/PropertySuggester.php
+++ b/extensions/PropertySuggester/PropertySuggester.php
@@ -9,7 +9,7 @@
return;
}
-define( 'PropertySuggester_VERSION', '2.4.4' );
+define( 'PropertySuggester_VERSION', '2.4.5' );
if ( file_exists( __DIR__ . '/vendor/autoload.php' ) ) {
require_once __DIR__ . '/vendor/autoload.php';
diff --git a/extensions/PropertySuggester/README.md
b/extensions/PropertySuggester/README.md
index c5d52c6..fa80664 100644
--- a/extensions/PropertySuggester/README.md
+++ b/extensions/PropertySuggester/README.md
@@ -45,6 +45,9 @@
## Release notes
+### 2.4.5 (2015-12-27)
+* Add i18n to the `wbsgetsuggestions` api module. This makes MediaWiki's
`ApiDocumentationTest` pass.
+
### 2.4.4 (2015-10-14)
* Fixed ResourceLoader dependencies of the `jquery.wikibase.entityselector`
module.
diff --git a/extensions/PropertySuggester/i18n/en.json
b/extensions/PropertySuggester/i18n/en.json
index ab5aaff..de3fb19 100644
--- a/extensions/PropertySuggester/i18n/en.json
+++ b/extensions/PropertySuggester/i18n/en.json
@@ -1,9 +1,23 @@
{
- "@metadata": {
- "authors": [
- "Christian Dullweber",
- "Katie Filbert"
- ]
- },
- "propertysuggester-desc": "Suggests properties when adding Wikibase
statements."
+ "@metadata": {
+ "authors": [
+ "Christian Dullweber",
+ "Katie Filbert"
+ ]
+ },
+ "propertysuggester-desc": "Suggests properties when adding Wikibase
statements.",
+ "apihelp-wbsgetsuggestions-description": "API module for getting
suggestions of additional properties to add to a Wikibase entity. The API
module is primarily intended for use by the suggester widget when users are
editing Wikibase entities.",
+ "apihelp-wbsgetsuggestions-example-1": "Get suggestions for entity Q4",
+ "apihelp-wbsgetsuggestions-example-2": "Get suggestions for entity Q4 from
rank 10 to 15",
+ "apihelp-wbsgetsuggestions-example-3": "Get suggestions for the property
combination P21 and P31",
+ "apihelp-wbsgetsuggestions-example-4": "Get suggestions for the qualifier
that are used with P21",
+ "apihelp-wbsgetsuggestions-example-5": "Get suggestions for the references
that are used with P21",
+ "apihelp-wbsgetsuggestions-param-context": "Either item, reference or
qualifier.",
+ "apihelp-wbsgetsuggestions-param-continue": "Offset where to continue a
search.",
+ "apihelp-wbsgetsuggestions-param-entity": "Suggest properties for the
given entity, based on existing list of properties that the entity has.",
+ "apihelp-wbsgetsuggestions-param-language": "Language for result.",
+ "apihelp-wbsgetsuggestions-param-limit": "Maximum number of results.",
+ "apihelp-wbsgetsuggestions-param-properties": "Suggest additional
properties for the given list of properties.",
+ "apihelp-wbsgetsuggestions-param-search": "Search for this text.",
+ "apihelp-wbsgetsuggestions-param-size": "Specify number of suggestions to
be returned."
}
diff --git a/extensions/PropertySuggester/i18n/qqq.json
b/extensions/PropertySuggester/i18n/qqq.json
index e2b9e9c..e5aec0f 100644
--- a/extensions/PropertySuggester/i18n/qqq.json
+++ b/extensions/PropertySuggester/i18n/qqq.json
@@ -1,8 +1,23 @@
{
"@metadata": {
"authors": [
- "Christian Dullweber"
+ "Christian Dullweber",
+ "Katie Filbert"
]
},
- "propertysuggester-desc":
"{{desc|name=PropertySuggester|url=http://www.mediawiki.org/wiki/Extension:PropertySuggester}}";
+ "propertysuggester-desc":
"{{desc|name=PropertySuggester|url=http://www.mediawiki.org/wiki/Extension:PropertySuggester}}";,
+ "apihelp-wbsgetsuggestions-description":
"{{doc-apihelp-description|wbsgetsuggestions}}",
+ "apihelp-wbsgetsuggestions-example-1":
"{{doc-apihelp-example|wbsgetsuggestions}}",
+ "apihelp-wbsgetsuggestions-example-2":
"{{doc-apihelp-example|wbsgetsuggestions}}",
+ "apihelp-wbsgetsuggestions-example-3":
"{{doc-apihelp-example|wbsgetsuggestions}}",
+ "apihelp-wbsgetsuggestions-example-4":
"{{doc-apihelp-example|wbsgetsuggestions}}",
+ "apihelp-wbsgetsuggestions-example-5":
"{{doc-apihelp-example|wbsgetsuggestions}}",
+ "apihelp-wbsgetsuggestions-param-context":
"{{doc-apihelp-param|wbgetsuggestions|context}}",
+ "apihelp-wbsgetsuggestions-param-continue":
"{{doc-apihelp-param|wbgetsuggestions|continue}}",
+ "apihelp-wbsgetsuggestions-param-entity":
"{{doc-apihelp-param|wbgetsuggestions|entity}}",
+ "apihelp-wbsgetsuggestions-param-language":
"{{doc-apihelp-param|wbgetsuggestions|language}}",
+ "apihelp-wbsgetsuggestions-param-limit":
"{{doc-apihelp-param|wbgetsuggestions|limit}}",
+ "apihelp-wbsgetsuggestions-param-properties":
"{{doc-apihelp-param|wbgetsuggestions|properties}}",
+ "apihelp-wbsgetsuggestions-param-search":
"{{doc-apihelp-param|wbgetsuggestions|search}}",
+ "apihelp-wbsgetsuggestions-param-size":
"{{doc-apihelp-param|wbgetsuggestions|size}}"
}
diff --git
a/extensions/PropertySuggester/src/PropertySuggester/GetSuggestions.php
b/extensions/PropertySuggester/src/PropertySuggester/GetSuggestions.php
index 6d41133..c496cc6 100644
--- a/extensions/PropertySuggester/src/PropertySuggester/GetSuggestions.php
+++ b/extensions/PropertySuggester/src/PropertySuggester/GetSuggestions.php
@@ -211,45 +211,20 @@
}
/**
- * @see ApiBase::getParamDescription()
+ * @see ApiBase::getExamplesMessages()
*/
- public function getParamDescription() {
+ public function getExamplesMessages() {
return array(
- 'entity' => 'Suggest attributes for given entity',
- 'properties' => 'Identifier for the site on which the
corresponding page resides',
- 'size' => 'Specify number of suggestions to be
returned',
- 'language' => 'language for result',
- 'limit' => 'Maximal number of results',
- 'context' => 'Either item, reference or qualifier',
- 'search' => 'Search for this text',
- 'continue' => 'Offset where to continue a search'
- );
- }
-
- /**
- * @see ApiBase::getDescription()
- */
- public function getDescription() {
- return array(
- 'API module to get property suggestions (e.g. when
editing data entities)'
- );
- }
-
- /**
- * @see ApiBase::getExamples()
- */
- public function getExamples() {
- return array(
- 'api.php?action=wbsgetsuggestions&entity=Q4'
- => 'Get suggestions for entity 4',
-
'api.php?action=wbsgetsuggestions&entity=Q4&continue=10&limit=5'
- => 'Get suggestions for entity 4 from rank 10 to 15',
- 'api.php?action=wbsgetsuggestions&properties=P31|P21'
- => 'Get suggestions for the property combination P21
and P31',
-
'api.php?action=wbsgetsuggestions&properties=P21&context=qualifier'
- => 'Get suggestions for the qualifier that are used
with P21',
-
'api.php?action=wbsgetsuggestions&properties=P21&context=reference'
- => 'Get suggestions for the references that are used
with P21'
+ 'action=wbsgetsuggestions&entity=Q4'
+ => 'apihelp-wbsgetsuggestions-example-1',
+ 'action=wbsgetsuggestions&entity=Q4&continue=10&limit=5'
+ => 'apihelp-wbsgetsuggestions-example-2',
+ 'action=wbsgetsuggestions&properties=P31|P21'
+ => 'apihelp-wbsgetsuggestions-example-3',
+
'action=wbsgetsuggestions&properties=P21&context=qualifier'
+ => 'apihelp-wbsgetsuggestions-example-4',
+
'action=wbsgetsuggestions&properties=P21&context=reference'
+ => 'apihelp-wbsgetsuggestions-example-5'
);
}
diff --git
a/extensions/PropertySuggester/tests/phpunit/PropertySuggester/GetSuggestionsTest.php
b/extensions/PropertySuggester/tests/phpunit/PropertySuggester/GetSuggestionsTest.php
index b424d73..908d566 100644
---
a/extensions/PropertySuggester/tests/phpunit/PropertySuggester/GetSuggestionsTest.php
+++
b/extensions/PropertySuggester/tests/phpunit/PropertySuggester/GetSuggestionsTest.php
@@ -136,16 +136,8 @@
$this->assertNotEmpty(
$this->getSuggestions->getAllowedParams() );
}
- public function testGetParamDescription() {
- $this->assertNotEmpty(
$this->getSuggestions->getParamDescription() );
- }
-
- public function testGetDescription() {
- $this->assertNotEmpty( $this->getSuggestions->getDescription()
);
- }
-
- public function testGetExamples() {
- $this->assertNotEmpty( $this->getSuggestions->getExamples() );
+ public function testGetExamplesMessages() {
+ $this->assertNotEmpty(
$this->getSuggestions->getExamplesMessages() );
}
}
diff --git a/vendor/composer/installed.json b/vendor/composer/installed.json
index bc0c96c..91b64bf 100644
--- a/vendor/composer/installed.json
+++ b/vendor/composer/installed.json
@@ -1460,17 +1460,17 @@
},
{
"name": "propertysuggester/property-suggester",
- "version": "2.4.4",
- "version_normalized": "2.4.4.0",
+ "version": "2.4.5",
+ "version_normalized": "2.4.5.0",
"source": {
"type": "git",
"url": "https://github.com/Wikidata-lib/PropertySuggester.git";,
- "reference": "398b914576947ceb8dedd803a9e15090f982fa25"
+ "reference": "96d2eeb9a3f926f9169e9bc150cc66440ea85ace"
},
"dist": {
"type": "zip",
- "url":
"https://api.github.com/repos/Wikidata-lib/PropertySuggester/zipball/398b914576947ceb8dedd803a9e15090f982fa25";,
- "reference": "398b914576947ceb8dedd803a9e15090f982fa25",
+ "url":
"https://api.github.com/repos/Wikidata-lib/PropertySuggester/zipball/96d2eeb9a3f926f9169e9bc150cc66440ea85ace";,
+ "reference": "96d2eeb9a3f926f9169e9bc150cc66440ea85ace",
"shasum": ""
},
"require": {
@@ -1482,7 +1482,7 @@
"phpunit/phpunit": "3.7.*",
"satooshi/php-coveralls": "dev-master"
},
- "time": "2015-10-14 21:06:09",
+ "time": "2015-12-27 10:13:49",
"type": "mediawiki-extension",
"installation-source": "dist",
"autoload": {
--
To view, visit https://gerrit.wikimedia.org/r/261181
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ib7c8251afb4ef72a3b12d0d2a08f006ae4175867
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Wikidata
Gerrit-Branch: master
Gerrit-Owner: WikidataBuilder <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
