jenkins-bot has submitted this change and it was merged.
Change subject: Unread notifications now visible
......................................................................
Unread notifications now visible
Unread notifications can now be differentiated from read ones.
Bug: T119597
Change-Id: Ibb5f37c711f65d4405670eac83af7ea8338b64d2
---
M resources/mobile.notifications.overlay/NotificationsOverlay.js
M resources/mobile.notifications.overlay/NotificationsOverlay.less
M resources/mobile.notifications.overlay/NotificationsOverlayContent.hogan
3 files changed, 13 insertions(+), 4 deletions(-)
Approvals:
Bmansurov: Looks good to me, approved
jenkins-bot: Verified
diff --git a/resources/mobile.notifications.overlay/NotificationsOverlay.js
b/resources/mobile.notifications.overlay/NotificationsOverlay.js
index a628489..e2330e6 100644
--- a/resources/mobile.notifications.overlay/NotificationsOverlay.js
+++ b/resources/mobile.notifications.overlay/NotificationsOverlay.js
@@ -66,7 +66,8 @@
notifications = $.map(
result.query.notifications.list, function ( a ) {
return {
message: a['*'],
- timestamp:
a.timestamp.mw
+ timestamp:
a.timestamp.mw,
+ unread: (
a.hasOwnProperty( 'read' ) ? 'mw-echo-notification-read' :
'mw-echo-notification-unread' )
};
} ).sort( function ( a, b ) {
return a.timestamp <
b.timestamp ? 1 : -1;
diff --git a/resources/mobile.notifications.overlay/NotificationsOverlay.less
b/resources/mobile.notifications.overlay/NotificationsOverlay.less
index 1b7d3dc..86e7822 100644
--- a/resources/mobile.notifications.overlay/NotificationsOverlay.less
+++ b/resources/mobile.notifications.overlay/NotificationsOverlay.less
@@ -46,9 +46,9 @@
.mw-echo-notification {
padding: 1.2em 1em 1em;
- border-bottom: 1px solid @colorGray14;
+ border-bottom: 1px solid @colorGray13;
// FIXME: ARgghghghg more grays - think of the children!
- background: #F8F8F8;
+ background: #F1F1F1;
&:hover {
// FIXME: Yet another gray..
@@ -56,6 +56,14 @@
}
}
+ .mw-echo-notification-unread {
+ background: white;
+
+ &:hover {
+ background-color: white;
+ }
+ }
+
.mw-echo-linked-notification {
cursor: pointer;
}
diff --git
a/resources/mobile.notifications.overlay/NotificationsOverlayContent.hogan
b/resources/mobile.notifications.overlay/NotificationsOverlayContent.hogan
index 58e69bf..a3ffc4c 100644
--- a/resources/mobile.notifications.overlay/NotificationsOverlayContent.hogan
+++ b/resources/mobile.notifications.overlay/NotificationsOverlayContent.hogan
@@ -2,7 +2,7 @@
{{#errorMessage}}<div class="content">{{errorMessage}}</div>{{/errorMessage}}
<ul class="mw-mf-notifications">
{{#notifications}}
- <li class="mw-echo-notification">
+ <li class="mw-echo-notification {{unread}}">
{{{message}}}
</li>
{{/notifications}}
--
To view, visit https://gerrit.wikimedia.org/r/260943
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ibb5f37c711f65d4405670eac83af7ea8338b64d2
Gerrit-PatchSet: 5
Gerrit-Project: mediawiki/extensions/MobileFrontend
Gerrit-Branch: master
Gerrit-Owner: Nicoco007 <[email protected]>
Gerrit-Reviewer: Bmansurov <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
