Bmansurov has uploaded a new change for review.
https://gerrit.wikimedia.org/r/261192
Change subject: Remove the 'search' event from Schema:MobileWebUIClickTracking
......................................................................
Remove the 'search' event from Schema:MobileWebUIClickTracking
Also reduce the sampling rate from the default 50% to 10%.
Bug: T108723
Change-Id: I8f037fd2349cd6219193b718f8344d086cfc7917
---
M includes/MobileFrontend.hooks.php
A resources/mobile.loggingSchemas/SchemaMobileWebUIClickTracking.js
M resources/mobile.references/ReferencesDrawer.js
M resources/mobile.toc/TableOfContents.js
M resources/skins.minerva.categories/init.js
M resources/skins.minerva.notifications/init.js
M resources/skins.minerva.scripts/init.js
M resources/skins.minerva.scripts/initLogging.js
M resources/skins.minerva.scripts/search.js
9 files changed, 42 insertions(+), 17 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/MobileFrontend
refs/changes/92/261192/1
diff --git a/includes/MobileFrontend.hooks.php
b/includes/MobileFrontend.hooks.php
index e409282..10b3ba4 100644
--- a/includes/MobileFrontend.hooks.php
+++ b/includes/MobileFrontend.hooks.php
@@ -1048,6 +1048,7 @@
'resources/mobile.loggingSchemas/SchemaEdit.js',
'resources/mobile.loggingSchemas/SchemaMobileWeb.js',
'resources/mobile.loggingSchemas/SchemaMobileWebClickTracking.js',
+
'resources/mobile.loggingSchemas/SchemaMobileWebUIClickTracking.js',
'resources/mobile.loggingSchemas/SchemaMobileWebWatching.js',
'resources/mobile.loggingSchemas/SchemaMobileWebSearch.js',
'resources/mobile.loggingSchemas/SchemaMobileWebSectionUsage.js',
diff --git a/resources/mobile.loggingSchemas/SchemaMobileWebUIClickTracking.js
b/resources/mobile.loggingSchemas/SchemaMobileWebUIClickTracking.js
new file mode 100644
index 0000000..1db1efd
--- /dev/null
+++ b/resources/mobile.loggingSchemas/SchemaMobileWebUIClickTracking.js
@@ -0,0 +1,21 @@
+( function ( M ) {
+ var SchemaMobileWebUIClickTracking,
+ SchemaMobileWebClickTracking = M.require(
+ 'mobile.loggingSchemas/SchemaMobileWebClickTracking' );
+
+ /**
+ * @class SchemaMobileWebUIClickTracking
+ * @extends SchemaMobileWebClickTracking
+ */
+ SchemaMobileWebUIClickTracking = SchemaMobileWebClickTracking.extend( {
+ /** @inheritdoc **/
+ name: 'MobileWebUIClickTracking',
+ /** @inheritdoc */
+ isSampled: true,
+ /** @inheritdoc */
+ samplingRate: 0.1
+ } );
+
+ M.define( 'mobile.loggingSchemas/SchemaMobileWebUIClickTracking',
+ SchemaMobileWebUIClickTracking );
+} )( mw.mobileFrontend );
diff --git a/resources/mobile.references/ReferencesDrawer.js
b/resources/mobile.references/ReferencesDrawer.js
index 99ffac2..0c3a14f 100644
--- a/resources/mobile.references/ReferencesDrawer.js
+++ b/resources/mobile.references/ReferencesDrawer.js
@@ -2,8 +2,9 @@
var ReferencesDrawer,
Drawer = M.require( 'mobile.drawers/Drawer' ),
Icon = M.require( 'mobile.startup/Icon' ),
- SchemaMobileWebClickTracking = M.require(
'mobile.loggingSchemas/SchemaMobileWebClickTracking' ),
- uiSchema = new SchemaMobileWebClickTracking( {},
'MobileWebUIClickTracking' );
+ SchemaMobileWebUIClickTracking = M.require(
+ 'mobile.loggingSchemas/SchemaMobileWebUIClickTracking'
),
+ uiSchema = new SchemaMobileWebUIClickTracking();
/**
* Drawer for references
diff --git a/resources/mobile.toc/TableOfContents.js
b/resources/mobile.toc/TableOfContents.js
index 9978c65..07ecf16 100644
--- a/resources/mobile.toc/TableOfContents.js
+++ b/resources/mobile.toc/TableOfContents.js
@@ -1,7 +1,8 @@
( function ( M ) {
var TableOfContents,
- SchemaMobileWebClickTracking = M.require(
'mobile.loggingSchemas/SchemaMobileWebClickTracking' ),
- uiSchema = new SchemaMobileWebClickTracking( {},
'MobileWebUIClickTracking' ),
+ SchemaMobileWebUIClickTracking = M.require(
+ 'mobile.loggingSchemas/SchemaMobileWebUIClickTracking'
),
+ uiSchema = new SchemaMobileWebUIClickTracking(),
View = M.require( 'mobile.view/View' ),
Icon = M.require( 'mobile.startup/Icon' );
diff --git a/resources/skins.minerva.categories/init.js
b/resources/skins.minerva.categories/init.js
index dedf3e1..ac0c09b 100644
--- a/resources/skins.minerva.categories/init.js
+++ b/resources/skins.minerva.categories/init.js
@@ -2,8 +2,9 @@
var loader = M.require( 'mobile.overlays/moduleLoader' ),
overlayManager = M.require( 'mobile.startup/overlayManager' ),
- MobileWebClickTracking = M.require(
'mobile.loggingSchemas/SchemaMobileWebClickTracking' ),
- uiSchema = new MobileWebClickTracking( {},
'MobileWebUIClickTracking' ),
+ SchemaMobileWebUIClickTracking = M.require(
+ 'mobile.loggingSchemas/SchemaMobileWebUIClickTracking'
),
+ uiSchema = new SchemaMobileWebUIClickTracking(),
user = M.require( 'mobile.user/user' );
// categories overlay
diff --git a/resources/skins.minerva.notifications/init.js
b/resources/skins.minerva.notifications/init.js
index 0e886f8..73facc1 100644
--- a/resources/skins.minerva.notifications/init.js
+++ b/resources/skins.minerva.notifications/init.js
@@ -3,8 +3,9 @@
* with the Toast notifications defined by common/toast.js.
*/
( function ( M, $, mw ) {
- var MobileWebClickTracking = M.require(
'mobile.loggingSchemas/SchemaMobileWebClickTracking' ),
- uiSchema = new MobileWebClickTracking( {},
'MobileWebUIClickTracking' ),
+ var SchemaMobileWebUIClickTracking = M.require(
+ 'mobile.loggingSchemas/SchemaMobileWebUIClickTracking'
),
+ uiSchema = new SchemaMobileWebUIClickTracking(),
mainMenu = M.require( 'skins.minerva.scripts/skin'
).getMainMenu(),
$btn = $( '#secondary-button.user-button' ).parent(),
router = M.require( 'mobile.startup/router' ),
diff --git a/resources/skins.minerva.scripts/init.js
b/resources/skins.minerva.scripts/init.js
index 5e846e1..ed71dba 100644
--- a/resources/skins.minerva.scripts/init.js
+++ b/resources/skins.minerva.scripts/init.js
@@ -12,8 +12,9 @@
useNewMediaViewer = context.isBetaGroupMember(),
overlayManager = M.require( 'mobile.startup/overlayManager' ),
page = M.getCurrentPage(),
- MobileWebClickTracking = M.require(
'mobile.loggingSchemas/SchemaMobileWebClickTracking' ),
- uiSchema = new MobileWebClickTracking( {},
'MobileWebUIClickTracking' ),
+ SchemaMobileWebUIClickTracking = M.require(
+ 'mobile.loggingSchemas/SchemaMobileWebUIClickTracking'
),
+ uiSchema = new SchemaMobileWebUIClickTracking(),
thumbs = page.getThumbnails(),
experiments = mw.config.get( 'wgMFExperiments' ) || {},
betaOptinPanel;
diff --git a/resources/skins.minerva.scripts/initLogging.js
b/resources/skins.minerva.scripts/initLogging.js
index eaa4271..ccb5863 100644
--- a/resources/skins.minerva.scripts/initLogging.js
+++ b/resources/skins.minerva.scripts/initLogging.js
@@ -1,10 +1,13 @@
// This initialises EventLogging for main menu and some prominent links in the
UI.
// This code should only be loaded on the Minerva skin, it does not apply to
other skins.
( function ( M, $ ) {
- var SchemaMobileWebClickTracking = M.require(
'mobile.loggingSchemas/SchemaMobileWebClickTracking' ),
+ var SchemaMobileWebClickTracking = M.require(
+ 'mobile.loggingSchemas/SchemaMobileWebClickTracking' ),
+ SchemaMobileWebUIClickTracking = M.require(
+ 'mobile.loggingSchemas/SchemaMobileWebUIClickTracking'
),
skin = M.require( 'skins.minerva.scripts/skin' ),
mainMenuSchema = new SchemaMobileWebClickTracking( {},
'MobileWebMainMenuClickTracking' ),
- uiSchema = new SchemaMobileWebClickTracking( {},
'MobileWebUIClickTracking' );
+ uiSchema = new SchemaMobileWebUIClickTracking();
$( function () {
var $profileLink = $( '#mw-mf-last-modified a' )
diff --git a/resources/skins.minerva.scripts/search.js
b/resources/skins.minerva.scripts/search.js
index a96930f..c47665e 100644
--- a/resources/skins.minerva.scripts/search.js
+++ b/resources/skins.minerva.scripts/search.js
@@ -1,8 +1,6 @@
( function ( M, $ ) {
var SearchOverlay, SearchGateway,
searchPlaceholderMsg = 'mobile-frontend-placeholder',
- SchemaMobileWebClickTracking = M.require(
'mobile.loggingSchemas/SchemaMobileWebClickTracking' ),
- uiSchema = new SchemaMobileWebClickTracking( {},
'MobileWebUIClickTracking' ),
context = M.require( 'mobile.context/context' ),
router = M.require( 'mobile.startup/router' ),
browser = M.require( 'mobile.browser/browser' ),
@@ -24,9 +22,6 @@
placeholder = $this.attr( 'placeholder' );
ev.preventDefault();
- uiSchema.log( {
- name: 'search'
- } );
mw.loader.using( moduleConfig.modules ).done( function () {
SearchGateway = M.require( moduleConfig.api );
--
To view, visit https://gerrit.wikimedia.org/r/261192
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I8f037fd2349cd6219193b718f8344d086cfc7917
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/MobileFrontend
Gerrit-Branch: master
Gerrit-Owner: Bmansurov <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
