Thiemo Mättig (WMDE) has uploaded a new change for review.
https://gerrit.wikimedia.org/r/261338
Change subject: More specific types in value validators
......................................................................
More specific types in value validators
Similar to what we do in formatters and parsers.
Change-Id: I3cb1171b699dba6efd0f03e238d87ea04b8d690a
---
M repo/includes/Validators/NumberValidator.php
M repo/tests/phpunit/includes/Validators/TestValidator.php
2 files changed, 2 insertions(+), 2 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Wikibase
refs/changes/38/261338/1
diff --git a/repo/includes/Validators/NumberValidator.php
b/repo/includes/Validators/NumberValidator.php
index b1a4365..f2c2930 100644
--- a/repo/includes/Validators/NumberValidator.php
+++ b/repo/includes/Validators/NumberValidator.php
@@ -15,7 +15,7 @@
/**
* @see ValueValidator::validate()
*
- * @param mixed $value The value to validate
+ * @param int|float $value The value to validate
*
* @return Result
*/
diff --git a/repo/tests/phpunit/includes/Validators/TestValidator.php
b/repo/tests/phpunit/includes/Validators/TestValidator.php
index 2824030..bc8eb95 100644
--- a/repo/tests/phpunit/includes/Validators/TestValidator.php
+++ b/repo/tests/phpunit/includes/Validators/TestValidator.php
@@ -26,7 +26,7 @@
}
/**
- * @param mixed $value
+ * @param string|DataValue $value
*
* @return Result
*/
--
To view, visit https://gerrit.wikimedia.org/r/261338
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I3cb1171b699dba6efd0f03e238d87ea04b8d690a
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Thiemo Mättig (WMDE) <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
