Gilles has uploaded a new change for review.
https://gerrit.wikimedia.org/r/261354
Change subject: Use shrink instead of resize
......................................................................
Use shrink instead of resize
The version of vips we use doesn't support resize, which was introduced
in a later version. This brings the VIPS engine closer to what mediawiki
is currently doing.
Bug: T119184
Change-Id: Ib9299211511d6205de48827c21e76fbcd7acd1eb
---
M wikimedia_thumbor_vips_engine/__init__.py
1 file changed, 8 insertions(+), 6 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/thumbor/vips-engine
refs/changes/54/261354/1
diff --git a/wikimedia_thumbor_vips_engine/__init__.py
b/wikimedia_thumbor_vips_engine/__init__.py
index 7b63bb7..835b1b0 100644
--- a/wikimedia_thumbor_vips_engine/__init__.py
+++ b/wikimedia_thumbor_vips_engine/__init__.py
@@ -13,6 +13,7 @@
import errno
import os
+import math
from tempfile import NamedTemporaryFile
from wikimedia_thumbor_base_engine import BaseWikimediaEngine
@@ -102,19 +103,20 @@
self.destination = NamedTemporaryFile(delete=False, suffix=extension)
- resize_factor = (
- float(self.context.request.width)
- /
+ shrink_factor = int(math.floor(
float(self.context.vips['width'])
- )
+ /
+ float(self.context.request.width)
+ ))
# Send a resized (but not cropped) image to PIL
command = [
self.context.config.VIPS_PATH,
- 'resize',
+ 'shrink',
source,
self.destination.name,
- "%f" % resize_factor
+ "%d" % shrink_factor,
+ "%d" % shrink_factor
]
result = self.exec_command(command)
self.extension = extension
--
To view, visit https://gerrit.wikimedia.org/r/261354
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ib9299211511d6205de48827c21e76fbcd7acd1eb
Gerrit-PatchSet: 1
Gerrit-Project: thumbor/vips-engine
Gerrit-Branch: master
Gerrit-Owner: Gilles <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
