jenkins-bot has submitted this change and it was merged.
Change subject: Moved JS files to end of body
......................................................................
Moved JS files to end of body
Improves loading and should fix code mirror init error
Bug: T120196
Change-Id: I8fc57d1c9036af29f02bc2e7a559331de704debc
---
M gui/index.html
1 file changed, 26 insertions(+), 24 deletions(-)
Approvals:
Smalyshev: Looks good to me, approved
Jonas Kress (WMDE): Looks good to me, approved
jenkins-bot: Verified
diff --git a/gui/index.html b/gui/index.html
index aec8fd3..313af58 100644
--- a/gui/index.html
+++ b/gui/index.html
@@ -1,30 +1,6 @@
<!doctype html>
<html>
<head>
-<script src="vendor/jquery/jquery-1.11.3.js"></script>
-<script src="vendor/bootstrap/js/bootstrap.min.js"></script>
-<script src="vendor/codemirror/lib/codemirror.js"></script>
-<script src="vendor/codemirror/mode/sparql.js"></script>
-<script src="vendor/codemirror/addon/hint/show-hint.js"></script>
-<script src="vendor/codemirror/addon/display/placeholder.js"></script>
-<script src="vendor/jqcloud/jqcloud-1.0.4.min.js"></script>
-<script src="vendor/bootstrap-tags/js/bootstrap-tags.min.js"></script>
-<script src="vendor/danml/download.min.js"></script>
-<script src="wikibase/codemirror/addon/hint/wikibase-sparql-hint.js"></script>
-<script src="wikibase/codemirror/addon/hint/wikibase-rdf-hint.js"></script>
-<script src="wikibase/codemirror/addon/tooltip/WikibaseRDFTooltip.js"></script>
-
-<script src="wikibase/queryService/ui/App.js"></script>
-<script src="wikibase/queryService/ui/Editor.js"></script>
-<script src="wikibase/queryService/ui/QueryExampleDialog.js"></script>
-<script src="wikibase/queryService/api/Sparql.js"></script>
-<script src="wikibase/queryService/api/QuerySamples.js"></script>
-<script src="wikibase/queryService/RdfNamespaces.js"></script>
-<script src="wikibase/init.js"></script>
-
-<script src="vis.js"></script>
-<script src="wdqs.js"></script>
-<script src="wdqs-explorer.js"></script>
<link rel="stylesheet" href="vendor/bootstrap/css/bootstrap.css">
<link rel="stylesheet" href="vendor/jqcloud/jqcloud.css">
@@ -175,5 +151,31 @@
</div>
</div>
</div>
+
+<!-- JS files -->
+ <script src="vendor/jquery/jquery-1.11.3.js"></script>
+ <script src="vendor/bootstrap/js/bootstrap.min.js"></script>
+ <script src="vendor/codemirror/lib/codemirror.js"></script>
+ <script src="vendor/codemirror/mode/sparql.js"></script>
+ <script src="vendor/codemirror/addon/hint/show-hint.js"></script>
+ <script src="vendor/codemirror/addon/display/placeholder.js"></script>
+ <script src="vendor/jqcloud/jqcloud-1.0.4.min.js"></script>
+ <script src="vendor/bootstrap-tags/js/bootstrap-tags.min.js"></script>
+ <script src="vendor/danml/download.min.js"></script>
+ <script
src="wikibase/codemirror/addon/hint/wikibase-sparql-hint.js"></script>
+ <script
src="wikibase/codemirror/addon/hint/wikibase-rdf-hint.js"></script>
+ <script
src="wikibase/codemirror/addon/tooltip/WikibaseRDFTooltip.js"></script>
+
+ <script src="wikibase/queryService/ui/App.js"></script>
+ <script src="wikibase/queryService/ui/Editor.js"></script>
+ <script src="wikibase/queryService/ui/QueryExampleDialog.js"></script>
+ <script src="wikibase/queryService/api/Sparql.js"></script>
+ <script src="wikibase/queryService/api/QuerySamples.js"></script>
+ <script src="wikibase/queryService/RdfNamespaces.js"></script>
+ <script src="wikibase/init.js"></script>
+
+ <script src="vis.js"></script>
+ <script src="wdqs.js"></script>
+ <script src="wdqs-explorer.js"></script>
</body>
</html>
--
To view, visit https://gerrit.wikimedia.org/r/260005
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I8fc57d1c9036af29f02bc2e7a559331de704debc
Gerrit-PatchSet: 1
Gerrit-Project: wikidata/query/rdf
Gerrit-Branch: master
Gerrit-Owner: Jonas Kress (WMDE) <[email protected]>
Gerrit-Reviewer: Jonas Kress (WMDE) <[email protected]>
Gerrit-Reviewer: Smalyshev <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
