Bartosz Dziewoński has uploaded a new change for review.
https://gerrit.wikimedia.org/r/261723
Change subject: Avoid widowing headers on category pages (in supporting
browsers)
......................................................................
Avoid widowing headers on category pages (in supporting browsers)
Avoid placing column breaks immediately following a header by
specifying `break-after: avoid-column` for them.
Unfortunately, only two browsers support this.
* Presto-based Opera, up to version 12 (but not the modern
Blink-based ones).
* Internet Explorer versions 10 and later (including Edge).
Better than nothing, I guess. As for other major players:
* Chrome accepts a `-webkit-column-break-after: avoid` property, but
it doesn't seem to result in correct rendering.
* I heard rumours that Firefox will treat `page-break-after: avoid` as
applying to columns too, but I've been unable to reproduce this.
I'm not including the broken properties, but implemented this as a
Less mixin, so that they can be easily added if support ever arrives.
Also corrected browser support commens in mixins about Opera.
Bug: T104541
Change-Id: I159e7b2a48bb60cda54026b44a482db17d38dfa8
---
M resources/src/mediawiki.action/mediawiki.action.view.categoryPage.less
M resources/src/mediawiki.less/mediawiki.mixins.less
2 files changed, 13 insertions(+), 4 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core
refs/changes/23/261723/1
diff --git
a/resources/src/mediawiki.action/mediawiki.action.view.categoryPage.less
b/resources/src/mediawiki.action/mediawiki.action.view.categoryPage.less
index ff25913..99d7e98 100644
--- a/resources/src/mediawiki.action/mediawiki.action.view.categoryPage.less
+++ b/resources/src/mediawiki.action/mediawiki.action.view.categoryPage.less
@@ -3,7 +3,12 @@
.mw-category {
.column-count(3);
.column-width(24em);
+
.mw-category-group {
+ h2 {
+ .column-break-after-avoid;
+ }
+
li {
.column-break-inside-avoid;
}
diff --git a/resources/src/mediawiki.less/mediawiki.mixins.less
b/resources/src/mediawiki.less/mediawiki.mixins.less
index 457e8c1..dd6f762 100644
--- a/resources/src/mediawiki.less/mediawiki.mixins.less
+++ b/resources/src/mediawiki.less/mediawiki.mixins.less
@@ -77,15 +77,19 @@
}
.column-width(@value) {
- -webkit-column-width: @value; // Chrome Any, Safari 3+, Opera 11.1+
+ -webkit-column-width: @value; // Chrome Any, Safari 3+, Opera 15+
-moz-column-width: @value; // Firefox 1.5+
- column-width: @value; // IE 10+
+ column-width: @value; // IE 10+, Opera 11.1-12.1
}
.column-break-inside-avoid() {
- -webkit-column-break-inside: avoid; // Chrome Any, Safari 3+, Opera
11.1+
+ -webkit-column-break-inside: avoid; // Chrome Any, Safari 3+, Opera 15+
page-break-inside: avoid; // Firefox 1.5+
- break-inside: avoid-column; // IE 10+
+ break-inside: avoid-column; // IE 10+, Opera 11.1-12.1
+}
+
+.column-break-after-avoid() {
+ break-after: avoid-column; // IE 10+, Opera 11.1-12.1
}
.flex-display(@display: flex) {
--
To view, visit https://gerrit.wikimedia.org/r/261723
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I159e7b2a48bb60cda54026b44a482db17d38dfa8
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Bartosz Dziewoński <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
