Ricordisamoa has uploaded a new change for review.
https://gerrit.wikimedia.org/r/261804
Change subject: Fix ApiElementProvider under Python 3
......................................................................
Fix ApiElementProvider under Python 3
The try/except block in .__iter__() was hiding
"TypeError: 'dict_values' object does not support indexing"
Change-Id: Ic70e006b4df45f0a3740adb6f9e76e4e8a3d2468
---
M chemistry.py
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.wikimedia.org:29418/labs/tools/ptable
refs/changes/04/261804/1
diff --git a/chemistry.py b/chemistry.py
index 5a05c90..4b515b8 100644
--- a/chemistry.py
+++ b/chemistry.py
@@ -212,7 +212,7 @@
except IndexError:
symbol = None
if 'labels' in entity and len(entity['labels']) == 1:
- label = entity['labels'].values()[0]['value']
+ label = list(entity['labels'].values())[0]['value']
else:
label = None
element = Element(number=number, symbol=symbol, item_id=entity['id'],
label=label)
--
To view, visit https://gerrit.wikimedia.org/r/261804
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ic70e006b4df45f0a3740adb6f9e76e4e8a3d2468
Gerrit-PatchSet: 1
Gerrit-Project: labs/tools/ptable
Gerrit-Branch: master
Gerrit-Owner: Ricordisamoa <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
