Jonas Kress (WMDE) has uploaded a new change for review.
https://gerrit.wikimedia.org/r/261986
Change subject: Make it easier to select example
......................................................................
Make it easier to select example
Changed links for pasting and editing an example
Change-Id: I53ad39879601de316e79401d6cbba6e45ca0678f
---
M gui/wikibase/queryService/ui/QueryExampleDialog.js
1 file changed, 7 insertions(+), 7 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/wikidata/query/rdf
refs/changes/86/261986/1
diff --git a/gui/wikibase/queryService/ui/QueryExampleDialog.js
b/gui/wikibase/queryService/ui/QueryExampleDialog.js
index 9c9b312..8328cb1 100644
--- a/gui/wikibase/queryService/ui/QueryExampleDialog.js
+++ b/gui/wikibase/queryService/ui/QueryExampleDialog.js
@@ -204,12 +204,12 @@
SELF.prototype._addExample = function( title, query, href, tags ) {
var self = this;
- var title = $( '<a>' ).text(title).attr( 'href', href ).attr(
'target', '_blank' ),
- tags = $( '<td/>' ).text( tags.join( '|' ) ).hide(),
- select = $( '<a href="#" title="Select this Query"
data-dismiss="modal">'
- +'<span class="glyphicon
glyphicon-copy" aria-hidden="true"></span></a>' ).click( function(){
- self._callback( query );
+ var link = $( '<a title="Select this query"
data-dismiss="modal">' ).text(title).attr( 'href', '#' ).click( function(){
+ self._callback( query );
} ),
+ tags = $( '<td/>' ).text( tags.join( '|' ) ).hide(),
+ edit = $( '<a title="Edit this Query">' ).attr( 'href',
href ).attr( 'target', '_blank' )
+ .append( '<span
class="glyphicon glyphicon-pencil" aria-hidden="true"></span></a>' ),
preview = $( '<span class="glyphicon
glyphicon-eye-open" aria-hidden="true"></span>' ).popover({
placement: 'bottom',
trigger: 'hover',
@@ -220,9 +220,9 @@
});
var example = $( '<tr/>' );
- example.append( $( '<td/>' ).append( title ) );
+ example.append( $( '<td/>' ).append( link ) );
example.append( $( '<td/>' ).append( preview ) );
- example.append( $( '<td/>' ).append( select ) );
+ example.append( $( '<td/>' ).append( edit ) );
example.append( tags );
this._$element.find( '.searchable' ).append( example );
--
To view, visit https://gerrit.wikimedia.org/r/261986
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I53ad39879601de316e79401d6cbba6e45ca0678f
Gerrit-PatchSet: 1
Gerrit-Project: wikidata/query/rdf
Gerrit-Branch: master
Gerrit-Owner: Jonas Kress (WMDE) <jonas.kr...@wikimedia.de>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
