Dzahn has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/262418

Change subject: ores: monitor workers without service reloads
......................................................................

ores: monitor workers without service reloads

Bug:T122830
Change-Id: I88ce6a4292b9e2c07106f97b52fb0b945e54c3ff
---
M modules/icinga/manifests/monitor/ores.pp
A modules/nagios_common/files/check_commands/check_ores_workers
A modules/nagios_common/files/check_commands/check_ores_workers.cfg
M modules/nagios_common/files/checkcommands.cfg
4 files changed, 23 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/operations/puppet 
refs/changes/18/262418/1

diff --git a/modules/icinga/manifests/monitor/ores.pp 
b/modules/icinga/manifests/monitor/ores.pp
index 2ee74ff..226b89a 100644
--- a/modules/icinga/manifests/monitor/ores.pp
+++ b/modules/icinga/manifests/monitor/ores.pp
@@ -13,12 +13,19 @@
     }
 
     # T121656
-    $timestamp = generate('/bin/date', '+%s')
     monitoring::service { 'ores_worker':
         description    => 'ORES worker',
-        check_command  => 
"check_http_url!ores.wmflabs.org!/scores/testwiki/reverted/${timestamp}/",
+        check_command  => 'check_http_ores',
         host           => 'ores.wmflabs.org',
         contact_group  => 'team-ores',
     }
 
+    # T122830
+    file { '/usr/local/lib/nagios/plugins/check_ores_workers':
+        source => 
'puppet:///modules/nagios_common/check_commands/check_ores_workers',
+        owner  => 'icinga',
+        group  => 'icinga',
+        mode   => '0550',
+    }
+
 }
diff --git a/modules/nagios_common/files/check_commands/check_ores_workers 
b/modules/nagios_common/files/check_commands/check_ores_workers
new file mode 100755
index 0000000..fed0d80
--- /dev/null
+++ b/modules/nagios_common/files/check_commands/check_ores_workers
@@ -0,0 +1,9 @@
+#!/bin/bash
+# monitor ORES (T121656, T122830)
+
+timestamp=$(/bin/date +%s)
+pluginpath="/usr/lib/nagios/plugins"
+host=$1
+
+$pluginpath/check_http -H $host -I $host -u 
"http://oresweb/scores/testwiki/reverted/${timestamp}/";
+
diff --git a/modules/nagios_common/files/check_commands/check_ores_workers.cfg 
b/modules/nagios_common/files/check_commands/check_ores_workers.cfg
new file mode 100644
index 0000000..da45942
--- /dev/null
+++ b/modules/nagios_common/files/check_commands/check_ores_workers.cfg
@@ -0,0 +1,4 @@
+define command {
+    command_name    check_ores_workers
+    command_line    $USER4$/check_ores_workers $ARG1$
+}
diff --git a/modules/nagios_common/files/checkcommands.cfg 
b/modules/nagios_common/files/checkcommands.cfg
index ec18696..7e289e9 100644
--- a/modules/nagios_common/files/checkcommands.cfg
+++ b/modules/nagios_common/files/checkcommands.cfg
@@ -498,3 +498,4 @@
     command_name    check_google_safebrowsing
     command_line    $USER1$/check_gsb.py $ARG1$ $ARG2$ $ARG3$
 }
+

-- 
To view, visit https://gerrit.wikimedia.org/r/262418
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I88ce6a4292b9e2c07106f97b52fb0b945e54c3ff
Gerrit-PatchSet: 1
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Dzahn <[email protected]>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to